Use existing Elasticsearch indices to speed up transfer during a restore#310
Merged
Conversation
sbryant
approved these changes
Jun 2, 2017
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When restoring Elasticsearch indices, leverage the
--copy-dest=rsyncoption so that any existing indices on the target appliance are used as a base.While
rsyncwould typically do this without needing this additional option, our use of a temporary staging directory -/data/user/elasticsearch-restore- necessitates the addition of this flag.This will help minimise unnecessary re-transfers of data during incremental restores, with the aim of only transferring data that has changed.
Testing has shown this brings improvements in various scenarios, and as yet no downside has been identified.
/cc @github/backup-utils