Change the condition in *ghe-host-check* when access through port 22 fails #304
Merged
Conversation
Member
|
This can be reproduced by adding a |
snh
suggested changes
May 16, 2017
| case $rc in | ||
| 255) | ||
| if echo "$output" | grep -i "port 22: connection refused\|port 22: no route to host\|ssh_exchange_identification: Connection closed by remote host\|Connection timed out during banner exchange" >/dev/null; then | ||
| if echo "$output" | grep -i "port 22: connection refused\|port 22: no route to host\|ssh_exchange_identification: Connection closed by remote host\|Connection timed out" >/dev/null; then |
Member
There was a problem hiding this comment.
To minimise the chances of this hiding issues with 122, can we leave the banner exchange match as is, and add a new one for port 22: Connection timed out, so that it only matches on 22?
Without this, it can get stuck in a loop if 22 and 122 both time out.
Contributor
Author
There was a problem hiding this comment.
Without this, it can get stuck in a loop if 22 and 122 both time out.
Ah yes, you're right. It'll loop.
snh
approved these changes
May 18, 2017
Merged
jeluhu
pushed a commit
that referenced
this pull request
Jun 12, 2023
Update requirements to help customers understand whether the rsync version on their backup host will work
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current condition:
can't catch the simple "Connection time out" error like:
So, I changed the condition a bit.