Suppress dd output noise#289
Merged
Merged
Conversation
``` Starting restore of rubiojr5.foobar.com:122 from snapshot 20170227T112756 rubiojr5-app-1: 0+1 records in rubiojr5-app-1: 0+1 records out rubiojr5-app-1: 10 bytes (10 B) copied, 7.1914e-05 s, 139 kB/s Error: rubiojr5.foobar.com:122 must be put in maintenance mode before restoring. Aborting. rubiojr5-app-1: 0+1 records in rubiojr5-app-1: 0+1 records out rubiojr5-app-1: 7 bytes (7 B) copied, 8.4164e-05 s, 83.2 kB/s ```
rubiojr
force-pushed
the
supress-dd-noise
branch
from
5a347c9 to
f66bd79
Compare
status=none is not available on precise, so use sponge instead to maintain backwards compatibility.
Member
|
I have confirmed that the updated |
rubiojr
commented
Apr 11, 2017
| packages: | ||
| - devscripts | ||
| - debhelper | ||
| - moreutils |
Member
Author
There was a problem hiding this comment.
Do we need moreutils/sponge installed on a Travis host?
Member
There was a problem hiding this comment.
Yes, it turns out this isn't on any of the targets we test on. See https://travis-ci.org/github/backup-utils/builds/206119031 for build failures before I added this to the travis hosts.
Member
Author
There was a problem hiding this comment.
Of course, forgot about mocking/stubs... 🙇
rubiojr
commented
Apr 11, 2017
rubiojr
left a comment
rubiojr
left a comment
Member
Author
There was a problem hiding this comment.
Have not verified to a cluster as yet.
Clustering shouldn't make a difference here, right?
snh
approved these changes
Apr 11, 2017
Merged
jeluhu
pushed a commit
that referenced
this pull request
Jun 12, 2023
Add multi stage build Dockerfile that compiles rsync from the source rsync repository
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
dd doesn't support
status=nonein GHE <= 2.5 (Precise) I think, so we may need a wrapper here, or just wait for 2.5 to be EOLd./cc @github/backup-utils