Skip to content

Backup and restore custom CA certificates#281

Merged
rubiojr merged 6 commits into
masterfrom
backup-utils/snh/ca-certs
Feb 23, 2017
Merged

Backup and restore custom CA certificates#281
rubiojr merged 6 commits into
masterfrom
backup-utils/snh/ca-certs

Conversation

@snh

@snh snh commented Feb 1, 2017

Copy link
Copy Markdown
Member

Using enhancements added in GitHub Enterprise 2.8.0, adds support for the backup and restore of custom CA certificates.

These certificates are only restored if an appliance is unconfigured, or the restore is performed with the -c flag.

Requires GitHub Enterprise 2.8.0 or later.

Fixes https://github.com/github/backup-utils/issues/163

/cc @github/backup-utils for review

@snh snh added the enhancement label Feb 1, 2017
@snh snh requested a review from rubiojr February 1, 2017 03:34
fi
fi

if ghe-ssh "$host" -- "which ghe-export-ssl-ca-certificates"; then

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've not tested this, but isn't this going to produce unnecessary output in the backup output? We might want to direct all output to /dev/null to be sure.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, that will write the path of that script when found.

@rubiojr rubiojr merged commit cde771c into master Feb 23, 2017
@rubiojr rubiojr deleted the backup-utils/snh/ca-certs branch February 23, 2017 11:50
@rubiojr rubiojr mentioned this pull request Mar 1, 2017
jeluhu pushed a commit that referenced this pull request Jun 12, 2023
fixing multiuser conditional argon secret backup
@jeluhu jeluhu mentioned this pull request Jun 12, 2023
JoeFranks1993 pushed a commit that referenced this pull request Jun 15, 2023
dooleydevin pushed a commit that referenced this pull request Jul 14, 2023
dooleydevin pushed a commit that referenced this pull request Jul 21, 2023
fixing multiuser conditional argon secret backup
@dooleydevin dooleydevin mentioned this pull request Jul 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants