ref(ui): Normalize wrapped component definitions - #121694
Open
scttcper wants to merge 2 commits into
Open
Conversation
Use named function components for memoized wrappers ahead of the lint migration. Let async select receive its ref directly now that the frontend is on React 19. Co-Authored-By: OpenAI Codex <[email protected]>
github-actions
Bot
added
the
Scope: Frontend
Contributor
📊 Type Coverage Diff
🔍 2 new type safety issues introduced
Type assertions (
This is informational only and does not block the PR. |
scttcper
marked this pull request as ready for review
August 11, 2026 15:38
# Conflicts: # static/app/components/core/select/async.tsx
natemoo-re
approved these changes
Aug 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Switches wrapped React components to named functions before the Oxlint migration