fix(issue-stream): remove progress sort option - #121686
Conversation
github-actions
Bot
added
the
Scope: Frontend
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
| IssueSortOptions.TRENDS, | ||
| IssueSortOptions.FREQ, | ||
| IssueSortOptions.USER, | ||
| ...(hasProgressSort ? [IssueSortOptions.PROGRESS] : []), | ||
| ]; | ||
|
|
||
| return ( |
There was a problem hiding this comment.
Bug: Users with the 'Progress' sort active will see "None" in the sort dropdown because the option was removed without a fallback for existing user states.
Severity: MEDIUM
Suggested Fix
Conditionally add IssueSortOptions.PROGRESS back to the list of available sort options if it is the currently active sort. This can be achieved by re-introducing a check similar to the removed sort === IssueSortOptions.PROGRESS guard, ensuring the UI remains consistent for users who previously selected this option.
Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent. Verify if this is a real issue. If it is, propose a fix; if not, explain why it's
not valid.
Location: static/app/views/issueList/actions/sortOptions.tsx#L87-L92
Potential issue: The 'Progress' sort option (`IssueSortOptions.PROGRESS`) has been
removed from the list of available sort options. However, there is no handling for users
who already have this sort option active, either from a URL parameter (`?sort=progress`)
or from `localStorage`. When the `CompactSelect` component receives `value="progress"`,
it cannot find a matching item in its `options` list. As a result, the component's
trigger label incorrectly displays "None" instead of the active sort, creating a
confusing UI state. The same issue affects the command palette, where the 'Progress'
sort option will be missing for these users.
Also affects:
static/app/views/issueList/issueListCommandPaletteActions.tsx:293~298
Did we get this right? 👍 / 👎 to inform future reviews.
There was a problem hiding this comment.
No users will have this, it wasn't released
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Want reviews to match your repository better? Bugbot Learning can learn team-specific rules from PR activity. A team admin can enable Learning in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 28b2fe5. Configure here.
| IssueSortOptions.TRENDS, | ||
| IssueSortOptions.FREQ, | ||
| IssueSortOptions.USER, | ||
| ...(hasProgressSort ? [IssueSortOptions.PROGRESS] : []), |
There was a problem hiding this comment.
Orphaned progress sort shows None
Medium Severity
Removing PROGRESS from sortKeys also drops the prior sort === IssueSortOptions.PROGRESS fallback. Persisted progress sorts (URL, localStorage, or saved views) leave CompactSelect with a value outside options, so the trigger shows None while the stream can still be progress-sorted. The same list is mirrored in the command palette.
Additional Locations (1)
Reviewed by Cursor Bugbot for commit 28b2fe5. Configure here.
2 participants
Remove "progress" from the issue stream sort selector, now that we are no longer using this sort in the stream