fix(test): Fix flaky EventGroupingInfo rendering test#111844
Draft
JoshuaKGoldberg wants to merge 1 commit intomasterfrom
Draft
fix(test): Fix flaky EventGroupingInfo rendering test#111844JoshuaKGoldberg wants to merge 1 commit intomasterfrom
JoshuaKGoldberg wants to merge 1 commit intomasterfrom
Conversation
github-actions
bot
added
the
Scope: Frontend
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
EventGroupingInfo > fetches and renders grouping info for errors(2 occurrences in last 30 days)FoldSection, which triggers a chain of async operations:React.lazymodule resolution, API fetch viauseApiQuery, and React re-render. ThefindByTextcall must wait for all three to complete, which occasionally exceeded the polling window under CI load.await waitFor(() => expect(groupingInfoRequest).toHaveBeenCalled())after the expand click to explicitly wait for the lazy-loaded component to resolve and fire the API query before asserting on rendered text.Test plan
CI=true pnpm test static/app/components/events/groupingInfo/groupingInfoSection.spec.tsxpasses (all 4 tests)Made with Cursor