fix(test): Fix flaky EventReplay inline onboarding test#111840
Draft
JoshuaKGoldberg wants to merge 1 commit intomasterfrom
Draft
fix(test): Fix flaky EventReplay inline onboarding test#111840JoshuaKGoldberg wants to merge 1 commit intomasterfrom
JoshuaKGoldberg wants to merge 1 commit intomasterfrom
Conversation
Made-with: Cursor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a flaky test in
static/app/components/events/eventReplay/index.spec.tsx:Root Cause
The
ReplayInlineOnboardingPanelcomponent is loaded viaReact.lazy(), creating an async code-splitting boundary. Inside that lazy-loaded component,usePromptcallsuseApiQuery(React Query), adding another async data-fetching boundary. The combination of these two async layers occasionally exceeded thefindByTextdefault timeout in CI, causing the test to flake.Fix
Mock the
replayInlineOnboardingPanelmodule (same pattern already used forreplayClipPreview) and assert on adata-test-idinstead of the rendered text. This eliminates both async boundaries — the lazy import and the prompt API call — making the test deterministic.The test's purpose is to verify that
EventReplaycorrectly decides to render the onboarding component when conditions are met, not to test the onboarding panel's internal rendering. Mocking the panel isolates the unit under test.Test plan
Made with Cursor