fix(test): Fix flaky DetectorsList bulk actions test#111839
Draft
JoshuaKGoldberg wants to merge 1 commit intomasterfrom
Draft
fix(test): Fix flaky DetectorsList bulk actions test#111839JoshuaKGoldberg wants to merge 1 commit intomasterfrom
JoshuaKGoldberg wants to merge 1 commit intomasterfrom
Conversation
Reduce the number of filtered detector fixtures from 20 to 3 in the "select all query results" test. Rendering 20 rows with multiple userEvent interactions (type, click, click, click) caused the test to occasionally exceed the 5000ms timeout under CI load. The test still validates the same "select all" behavior with fewer rows. X-Hits header adjusted from 50 to 10 accordingly. Co-Authored-By: Claude Sonnet 4 <[email protected]> Made-with: Cursor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DetectorsList › bulk actions › shows option to select all query results when page is selectedtestuserEventinteractions (type search query, click row, click checkbox, click master checkbox, click select-all, click delete, confirm modal). The combination of rendering 20 rows plus ~10 user interactions occasionally exceeded the 5000ms Jest timeout under CI load.X-Hitsheader from50to10), which significantly reduces rendering and re-render time while still validating the same "select all query results" bulk action behavior.Test plan
allMonitors.spec.tsxpass locallyMade with Cursor