fix(test): Fix flaky customerDetails billing permissions test#111838
Draft
JoshuaKGoldberg wants to merge 1 commit intomasterfrom
Draft
fix(test): Fix flaky customerDetails billing permissions test#111838JoshuaKGoldberg wants to merge 1 commit intomasterfrom
JoshuaKGoldberg wants to merge 1 commit intomasterfrom
Conversation
The tooltip on disabled menu items in CompactSelect/MenuListItem has a 500ms delay before appearing. Under CI load, this delay plus React render time can exceed findByText's default 1000ms timeout, causing intermittent failures. Extend the timeout to 2000ms. Co-Authored-By: Claude Sonnet 4 <[email protected]> Made-with: Cursor
github-actions
bot
added
the
Scope: Frontend
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix flaky test
Customer Details › change legacy soft cap › renders disabled without billing.admin permissionsincustomerDetails.spec.tsx.The test hovers over a disabled
CompactSelectmenu item and asserts that a tooltip with "Requires billing admin permissions." appears.MenuListItemrenders tooltips with a default 500ms delay (tooltipOptions = {delay: 500}), so the tooltip text only appears in the DOM after that delay plus React render time. Under CI load, this combined time can exceedfindByText's default 1000ms timeout, causing intermittent failures.The fix extends the
findByTexttimeout to 2000ms, giving comfortable headroom for the 500ms tooltip delay plus render time even under heavy CI load.Made with Cursor