fix(test): Fix flaky StackTrace URL link tooltip test#111835
Draft
JoshuaKGoldberg wants to merge 1 commit intomasterfrom
Draft
fix(test): Fix flaky StackTrace URL link tooltip test#111835JoshuaKGoldberg wants to merge 1 commit intomasterfrom
JoshuaKGoldberg wants to merge 1 commit intomasterfrom
Conversation
Made-with: Cursor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a flaky test in
stackTrace.spec.tsx— the testshows URL link in tooltip when absPath is an http URLwas failing intermittently (5 occurrences in 30 days).Root cause: The test uses
jest.useFakeTimers()to advance past the tooltip's 1000ms open delay. Afteract(() => jest.advanceTimersByTime(2000)), the tooltip content (including an<a>link) should be in the DOM. However,findByRole('link', ...)internally useswaitForwhich polls viasetTimeout— and with fake timers still active, these polling timeouts don't fire reliably, causing the query to intermittently time out.Fix: Move
jest.useRealTimers()before thefindByRoleassertion instead of after it. This ensures:findByRole's internal polling mechanism works correctlypointerleaveevent has been triggeredThis matches the pattern used by similar passing tests in the same file that use
findByText(which succeeds on its first synchronous check, avoiding the polling issue).Test plan
stackTrace.spec.tsxpassMade with Cursor