feat(dashboards): adds dashboards generate endpoint#110254
feat(dashboards): adds dashboards generate endpoint#110254edwardgou-sentry merged 9 commits intomasterfrom
Conversation
github-actions
bot
added
the
Scope: Backend
github-actions
bot
added
the
Scope: Frontend
|
🚨 Warning: This pull request contains Frontend and Backend changes! It's discouraged to make changes to Sentry's Frontend and Backend in a single pull request. The Frontend and Backend are not atomically deployed. If the changes are interdependent of each other, they must be separated into two pull requests and be made forward or backwards compatible, such that the Backend or Frontend can be safely deployed independently. Have questions? Please ask in the |
![sentry-warden[bot]](https://avatars.githubusercontent.com/in/2755838?s=60&v=4){kind=small}
…om:getsentry/sentry into egou/feat/seer-generate-dashboard-endpoint
| ): | ||
| return Response({"detail": "Feature not enabled"}, status=403) | ||
|
|
||
| has_access, error = has_seer_access_with_detail(organization, request.user) |
There was a problem hiding this comment.
are we constraining this to only users with seer billing?
There was a problem hiding this comment.
This endpoint/feature will only be for internal testing to validate the artifacts we're building. It won't be released to any customers.
Our end goal is to have our Dashboard artifacts be integrated into Seer Explorer, we're just waiting for the platform changes to support that use case a bit better so that we can inject our artifact in some way. Once we reach that state, I believe the plan may be to allow Dashboard creation via Seer without needing billing. We're still figuring out this experience though.
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
src/sentry/dashboards/endpoints/organization_dashboard_generate.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 3 potential issues.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
src/sentry/dashboards/endpoints/organization_dashboard_generate.py
Outdated
Show resolved
Hide resolved
tests/sentry/dashboards/endpoints/test_organization_dashboard_generate.py
Show resolved
Hide resolved
tests/sentry/dashboards/endpoints/test_organization_dashboard_generate.py
Show resolved
Hide resolved
|
drafting to fix a few things |
DominikB2014
left a comment
DominikB2014
left a comment
There was a problem hiding this comment.
Lgtm! although there might be some opportunity to share code/types with the serializer/dashboard backend, artifact, etc
3 participants
GeneratedDashboardartifact, for building dashboard and widget payloads via Seerdashboards/generate/endpoint that start a new seer run using the newGeneratedDashboardartifact