feat(aci): Update copy on metric alert wizard to refernce issue creation #109223
feat(aci): Update copy on metric alert wizard to refernce issue creation #109223
Conversation
…is on When the workflow-engine-metric-issue-ui feature flag is enabled, update the alert wizard panel descriptions to explain that alerts now create issues with threshold-based creation, resolution, re-opening, and issue priority. Applies to all metric alert types: errors, sessions, performance, spans, and logs. Co-Authored-By: Claude <[email protected]>
github-actions
bot
added
the
Scope: Frontend
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
| ) | ||
| : t( | ||
| 'Throughput is the total number of transactions in a project and you can alert when it reaches a threshold within a period of time.' | ||
| ), |
There was a problem hiding this comment.
Legacy transaction alert descriptions incorrectly reference "spans"
Medium Severity
The hasMetricIssues descriptions for legacy transaction-based alert types (throughput, trans_duration, failure_rate) incorrectly reference "spans" instead of "transactions." These alert types use Dataset.TRANSACTIONS and are shown when deprecateTransactionAlerts returns false, which is controlled by a separate feature flag (discover-saved-queries-deprecation) from hasMetricIssues (workflow-engine-metric-issue-ui). When hasMetricIssues is enabled but transaction alerts aren't deprecated, users see descriptions mentioning "spans" for transaction-based alerts, which is misleading.
Additional Locations (2)
| ? tct( | ||
| "This alert creates issues when the percentage of crash sessions crosses your set thresholds. Setting thresholds will determine when an issue is [em:created], [em:resolved], and [em:re-opened], as well as the [em:issue priority]. A session begins when a user starts the application, and ends when it's closed or sent to the background. A crash is when a session ends due to an error. You will also be alerted when your set thresholds are crossed. This lets you get a better picture of the health of your app.", | ||
| {em: <em />} | ||
| ) |
There was a problem hiding this comment.
Missing "free" inverts crash-free sessions description meaning
Medium Severity
The crash_free_sessions hasMetricIssues description says "percentage of crash sessions" but the metric is CRASH_FREE_SESSIONS and the alert is named "Crash Free Session Rate." The word "free" is missing, making it sound like the alert tracks crash sessions rather than crash-free sessions — the opposite of what it measures. The sibling crash_free_users entry correctly says "percentage of crash free users," confirming this is an oversight.
2 participants
Closes https://linear.app/getsentry/issue/ISWF-2091/metric-alerts-update-selector-copy-to-describe-issue-creation
See https://www.notion.so/sentry/Metric-Type-Copy-for-Selectors-2fc8b10e4b5d808ab737e5fed41c9b44