fix(dashboards): use spans dataset in default overview dashboard backend#108682
fix(dashboards): use spans dataset in default overview dashboard backend#108682nikkikapadia merged 4 commits intomasterfrom
Conversation
github-actions
bot
added
the
Scope: Backend
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
| response = self.do_request("put", self.url(slug), data=data) | ||
| assert response.status_code == 400, response.data |
There was a problem hiding this comment.
Wait, can we confirm if we actually do PUT against the default-overview dashboard? I would have thought that we should trigger a POST with the new dashboard to create something new because.. we can't update this, unless the code detects it and spits out a new dashboard 🤔
It might be a bug in the frontend then if we don't try to post. Which now that I think of feels like it could be the case.
There was a problem hiding this comment.
If that's the case, I don't think this test is necessary because we shouldn't ever be trying to update this hardcoded dashboard
There was a problem hiding this comment.
so basically the way it works is when you go to update the default-overview dashboard it will delete the dashboard and create a new custom dashboard BUT that default overview dashboard will create a DashboardTombstone so that's what these PUT tests were testing. For this test in particular I was making sure it didn't accept the PUT with a transactions widget being passed in.
| def get_prebuilt_dashboards(organization, user) -> list[dict[str, Any]]: | ||
| error_events_type = DashboardWidgetTypes.get_type_name(DashboardWidgetTypes.ERROR_EVENTS) | ||
| transaction_type = DashboardWidgetTypes.get_type_name(DashboardWidgetTypes.TRANSACTION_LIKE) | ||
| transaction_type = ( |
There was a problem hiding this comment.
Do we also need to update the query condition for the transaction widget to include is_segment:True or something? because otherwise it's aggregating spans and the counts would be for spans and not necessarily transactions
There was a problem hiding this comment.
oh true good point! i'll update that
…end (#108682) when we deprecated the spans dataset in the dashboard/widget templates we forgot to do the default overview backend endpoint 🤩 Closes [DAIN-1197](https://linear.app/getsentry/issue/DAIN-1197/cannot-add-a-widget-to-a-dashboard)
…end (#108682) when we deprecated the spans dataset in the dashboard/widget templates we forgot to do the default overview backend endpoint 🤩 Closes [DAIN-1197](https://linear.app/getsentry/issue/DAIN-1197/cannot-add-a-widget-to-a-dashboard)
2 participants
when we deprecated the spans dataset in the dashboard/widget templates we forgot to do the default overview backend endpoint 🤩
Closes DAIN-1197