feat(occurrences on eap): Implement EAP read for trace-connected issues in related issues calculation by shashjar · Pull Request #105459 · getsentry/sentry

shashjar · 2025-12-26T15:38:51Z

The RelatedIssuesEndpoint has logic which can retrieve issues associated with the same trace as the one included in the request. This PR adds logic which uses an EndpointTraceItemTable RPC query to retrieve trace-connected issues.

Tested locally to ensure that the reads are succeeding and the results are matching that of the legacy Snuba read path:

sentry.issues.related.trace_connected: Snuba results: [18, 19]

sentry.utils.snuba_rpc: Running a EndpointTraceItemTable RPC query (
  rpc_query={
    'meta': {
      'organizationId': '1',
      'referrer': 'api.issues.related_issues',
      'projectIds': ['1', '2', '3'],
      'startTimestamp': '2025-09-30T21:07:44.639036Z',
      'endTimestamp': '2025-12-29T21:07:44.639036Z',
      'traceItemType': 'TRACE_ITEM_TYPE_OCCURRENCE',
      'downsampledStorageConfig': {'mode': 'MODE_HIGHEST_ACCURACY'}
    },
    'columns': [
      {'key': {'type': 'TYPE_INT', 'name': 'group_id'}, 'label': 'group_id'},
      {'aggregation': {'aggregate': 'FUNCTION_COUNT', 'key': {'type': 'TYPE_INT', 'name': 'sentry.project_id'}, 'label': 'count()', 'extrapolationMode': 'EXTRAPOLATION_MODE_SAMPLE_WEIGHTED'}, 'label': 'count()'}
    ],
    'filter': {
      'comparisonFilter': {
        'key': {'type': 'TYPE_STRING', 'name': 'sentry.trace_id'},
        'op': 'OP_EQUALS',
        'value': {'valStr': '4bf92f3577b34da6a3ce929d0e0e4736'}
      }
    },
    'groupBy': [{'type': 'TYPE_INT', 'name': 'group_id'}],
    'limit': 100,
    'pageToken': {'offset': '0'}
  }
  referrer='api.issues.related_issues'
  organization_id=1
  trace_item_type=7
)

sentry.utils.snuba_rpc: Table RPC query response (
  rpc_rows=3
  organization_id=1
  page_token=offset: 3
  meta=request_id: "941d7f60e1374414a81690b59f5fe218"
  query_info { stats { progress_bytes: 780 } metadata { } }
  downsampled_storage_meta { }
)

sentry.issues.related.trace_connected: Raw EAP results: {
  'data': [
    {'group_id': 18, 'count()': 2.0},
    {'group_id': 19, 'count()': 1.0},
    {'group_id': 17, 'count()': 3.0}
  ],
  'meta': {'fields': {'group_id': 'integer', 'count()': 'integer'}, 'full_scan': True, 'bytes_scanned': 780},
  'confidence': [{'count()': 'high'}, {'count()': 'high'}, {'count()': 'high'}]
}

sentry.issues.related.trace_connected: EAP results: [18, 19]

sentry.issues.related.trace_connected: Snuba results same as EAP results: True

…ues endpoint) from EAP

src/sentry/issues/related/trace_connected.py

shashjar · 2025-12-29T21:15:30Z

src/sentry/issues/related/trace_connected.py

+        result = Occurrences.run_table_query(
+            params=snuba_params,
+            query_string=f"trace:{trace_id}",
+            selected_columns=["group_id", "count()"],


Have a count() here in order to get distinct group IDs back

…p-for-related-issues

thetruecpaul

Left some nits/ Qs

thetruecpaul · 2025-12-30T19:24:05Z

src/sentry/issues/related/trace_connected.py

+                gid = int(group_id)
+                if gid != exclude_group_id:
+                    group_ids.add(gid)
+        return list(group_ids)


Is there any expectation of ordering from this endpoint?

I don't believe so, since the Snuba implementation also relies on a set. But this does raise a good point in that our Snuba/EAP result comparisons will potentially mismatch even when the group ID sets are the same, since we're comparing the lists instead of the sets. Going to refactor these functions to return the set values so we can check_and_choose on those instead, and then the endpoint can convert to list before returning.

thetruecpaul · 2025-12-30T19:24:25Z

src/sentry/issues/related/trace_connected.py

+    except Exception:
+        logger.exception(
+            "Fetching trace connected issues from EAP failed",
+            extra={


Can you log the actual exception message as well?

I believe logger.exception automatically captures the exception value when used in an except block

thetruecpaul · 2025-12-30T19:26:03Z

src/sentry/issues/related/trace_connected.py

+            projects=projects,
+            exclude_group_id=group.id,
+        )
+        issues = EAPOccurrencesComparator.check_and_choose(


Is there a way to do a reasonable-comparison here? (EAP subset of Snuba?)

Can you add is-null-result here?

Yeah, good idea. I'll refactor to do the exact match comparison using the set versions, and then also add a reasonable match comparator checking if the EAP version is a subset of the Snuba version. And sure, I'll add the is_experimental_data_a_null_result param for when the EAP result is empty.

thetruecpaul · 2025-12-30T19:26:40Z

tests/sentry/issues/related/test_trace_connected.py

@@ -0,0 +1,155 @@
+from unittest import mock


Note: I see you've added empty file tests/sentry/issues/related/__init__.py. Is this intentional?

Yep, I believe necessary for the directory to be picked up as a py module

Implement double reads of trace-connected issues (for the related iss…

907e632

…ues endpoint) from EAP

github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Dec 26, 2025

shashjar commented Dec 26, 2025

View reviewed changes

src/sentry/issues/related/trace_connected.py Show resolved Hide resolved

Add count() aggregation to query to get distinct group IDs only

c6446d0

shashjar commented Dec 29, 2025

View reviewed changes

shashjar requested review from a team and thetruecpaul December 29, 2025 21:15

Merge branch 'master' into double-read-trace-connected-issues-from-ea…

6640ee4

…p-for-related-issues

shashjar marked this pull request as ready for review December 29, 2025 21:16

shashjar requested review from a team as code owners December 29, 2025 21:16

shashjar removed request for a team December 29, 2025 21:17

vercel bot deployed to Preview December 29, 2025 21:18 View deployment

Fix typing issues

bd7e4d9

vercel bot deployed to Preview December 29, 2025 21:39 View deployment

thetruecpaul approved these changes Dec 30, 2025

View reviewed changes

Improve metric tracking of EAP vs. Snuba results

ff55df4

vercel bot deployed to Preview December 31, 2025 16:35 View deployment

shashjar merged commit b8772bc into master Dec 31, 2025
65 checks passed

shashjar deleted the double-read-trace-connected-issues-from-eap-for-related-issues branch December 31, 2025 18:55

github-actions bot mentioned this pull request Jan 10, 2026

ci(release): Switch from action-prepare-release to Craft #106005

Merged

github-actions bot locked and limited conversation to collaborators Jan 16, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat(occurrences on eap): Implement EAP read for trace-connected issues in related issues calculation#105459

feat(occurrences on eap): Implement EAP read for trace-connected issues in related issues calculation#105459
shashjar merged 5 commits intomasterfrom
double-read-trace-connected-issues-from-eap-for-related-issues

shashjar commented Dec 26, 2025 •

edited

Loading

Uh oh!

Uh oh!

shashjar Dec 29, 2025

Uh oh!

thetruecpaul left a comment

Uh oh!

thetruecpaul Dec 30, 2025

Uh oh!

shashjar Dec 30, 2025

Uh oh!

thetruecpaul Dec 30, 2025

Uh oh!

shashjar Dec 30, 2025

Uh oh!

thetruecpaul Dec 30, 2025

Uh oh!

shashjar Dec 30, 2025

Uh oh!

thetruecpaul Dec 30, 2025

Uh oh!

shashjar Dec 30, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

shashjar commented Dec 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

thetruecpaul left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

shashjar commented Dec 26, 2025 •

edited

Loading