Conversation
github-actions
bot
added
the
Scope: Backend
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #105097 +/- ##
===========================================
+ Coverage 79.20% 80.62% +1.42%
===========================================
Files 9407 9410 +3
Lines 403551 403596 +45
Branches 25636 25636
===========================================
+ Hits 319641 325408 +5767
+ Misses 83441 77719 -5722
Partials 469 469 |
shashjar
changed the title
shashjar
deleted the
add-retry-policy-with-exponential-backoff-for-eap-delete-rpc-requests
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves SENTRY-5DCB. Resolves SENTRY-5DCN.
This PR adds a retry policy & exponential backoff for delete RPC requests that we issue to EAP, to hopefully respond in a healthy way to Snuba rate-limiting.
We may also want to loosen the Snuba rate limit policy at some point in the future, since the number of delete requests we issued to start getting rate-limited wasn't excessive (metrics).