Closed
Conversation
Contributor
|
Alternatively, you might choose to reconsider using edition 2024 so quickly, because you might not have intended to impose MSRV 1.85 on everything that uses this crate directly or indirectly (and doesn’t yet use the Rust-version-aware resolver). Explicitly declaring an MSRV is a good idea, either way. |
Owner
|
I wanted to go the path suggested by @musicinmybrain. In #65 I undid some of the latest changes and I got I would appreciate your review of the changes. If everything is fine, I'll merge that in and release a new version. |
Contributor
Author
|
Closing in favour of #65 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the MSRV to Cargo.toml, so it gets listed on crates.io (and it can be read by the Rust-version aware resolver).
6422a96 updated the crate to edition 2024, so it only compiles with
rust>=1.85.The badge on the README will render the correct version once the next release is published.