Make change_priority API consistent#41
Merged
garro95 merged 4 commits intogarro95:masterfrom Nov 10, 2022
Merged
Conversation
Owner
|
I would rather return a use priority_queue::PriorityQueue;
use std::mem::swap;
let mut pq = PriorityQueue::new();
pq.push("Apples", 5);
pq.push("Bananas", 8);
pq.push("Strawberries", 23);
let mut newp = Some(10);
pq.change_priority_by("Bananas", |p| {
swap(p, newp.as_mut().unwrap());
});
let oldp = newp;
assert_eq!(pq.get("Bananas"), Some((&"Bananas", &10)));
assert_eq!(oldp, Some(8)); |
Contributor
Author
|
Make sense to me. I will update the PR :-) Either |
Owner
|
Would you also be so kind to update the |
Owner
|
Thanks for your contribution |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently for either
PriorityQueueorDoublePriorityQueue, the return value forchange_priorityandchange_priority_byfunctions are different.In some cases where a customized (and complicated) struct P is used,
change_priority_byis usually preferred which provides flexibility to update the underlying structure. However, due to nothing is returned, the caller has no idea whether the update is successful or not. There are few optionschange_priority_byreturn anOptiontype (same aschange_priorityget_priorityfirst. Based on result and then callchange_priority_bypush2 and 3 are obviously not ideal, as Option2 caused IndexMap lookup twice; Option3 may cause a clone
This PR submits code change for Option1