This repository was archived by the owner on Aug 22, 2020. It is now read-only.
Fixed a case in which the title was being truncated#20
Merged
Conversation
When using multiple lines in the title, the text is being truncated at the top due to the top margin being set to a negative margin. Now only adding the margin when the value is not negative.
Owner
|
Thanks for contributions. |
Contributor
Author
|
Great! Thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While using this library, I encountered an issue in which the step titles were being truncated when using multi-line texts.
This is due to the top margin of the title getting a negative margin. Resulting in the truncated title.
The current issues did not describe this, only in issue #15 it is mentioned (which is closed).
Instead of reporting it, I have fixed it in the library itself.
It can easily be tested in the demo project. Just set the step titles to a long title resulting in a multiline title. Then going to step 2 and back to step 1, the title of the first step is truncated.
This fix just prevents the negative margin to prevent the truncated title.
For reference, check out the following screenshots when applying this fix in the demo project: (enabled showing layout-bounds)
Earlier (with bug):
And when going to step 2 and back:
Now (with fix applied):
