feat: Remove moment js - #302
Merged
Merged
Conversation
mertkirbuga
added
enhancement
mertkirbuga
commented
May 28, 2025
Comment on lines
+334
to
+338
| // Ensure that the dayjs object is in local time zone and format | ||
| // to timezone naive string. | ||
| return { | ||
| __type__: "datetime", | ||
| value: moment(date).local().format(ENCODE_DATETIME_FORMAT), | ||
| value: dayjs.utc(date).local().format(ENCODE_DATETIME_FORMAT), |
Contributor
Author
There was a problem hiding this comment.
Should we remove this also? @jimmycallin
Contributor
Author
There was a problem hiding this comment.
Do we need an alternative to replace this? Because in this case, when serverInformation and timezone is enabled we will return an object { __type__: "datetime", value:date }. Otherwise, we will return the data instead of date.
Contributor
There was a problem hiding this comment.
is_timezone_support_enabled is a separate from recently implemented use_workspace_timezone_enabled - it's an old flag that should always be enabled. we can remove this check and only support when it's true.
Contributor
Author
There was a problem hiding this comment.
Still a bit uncertain about my implementation. Can you check this commit f71e035?
jimmycallin
changed the title
jimmycallin
reviewed
May 30, 2025
jimmycallin
reviewed
Jun 4, 2025
jimmycallin
approved these changes
Jun 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves F-168
Changes
All moment js instances is replaced by dayjs instances.
Test
TBD