yaml-actionlint: only allow inside GitHub workflows dir#2083
Merged
bbatsov merged 1 commit intoflycheck:masterfrom Jul 26, 2024
Merged
yaml-actionlint: only allow inside GitHub workflows dir#2083bbatsov merged 1 commit intoflycheck:masterfrom
bbatsov merged 1 commit intoflycheck:masterfrom
Conversation
Contributor
Agreed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Right now, with the default chain and priority setup, the
yaml-actionlintchecker is running first for all YAML files. For anything outside of a repository's.github/workflows(not.github!) directory, this checker doesn't make sense.Without modifying the YAML checker chain, this patch stops
actionlintfrom running on files outside this directory. I also tried to handle Windows but I'm not sure if.github\\workflowsis the correct path.I think this checker should be added to the chains after
yaml-yamllintbut wanted to make this change first.