Merged
Conversation
Member
Yes, I'd suggest adding that to any checker which uses |
fmdkdd
force-pushed
the
fix-1417-freeze-opening-haskell-file
branch
from
255e4cc to
cfb167a
Compare
Member
Author
|
@flycheck/haskell Updated. Do you think we can land this? |
purcell
approved these changes
Apr 20, 2018
Member
purcell
left a comment
purcell
left a comment
There was a problem hiding this comment.
I'm not 100% convinced that on-demand GHC installation was the root of the related issue, but this is at least harmless, so I'll go ahead and merge it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should fix #1417.
Although since we have an
ignore-errorsin there, I'm not sure what happens ifstackcannot find GHC. Probablyoutputis nil, then we return the location of the cabal file, if any.Maybe we need to pass
--no-install-ghcto thestackinvocation inhaskell-stack-ghcas well?WDYT @flycheck/haskell ?