Skip to content

Add scrollPadding property to DropdownMenuFormField - #184059

Draft
Hamidrzash wants to merge 4 commits into
flutter:masterfrom
Hamidrzash:add-scroll-padding-to-dropdown-form-field
Draft

Add scrollPadding property to DropdownMenuFormField#184059
Hamidrzash wants to merge 4 commits into
flutter:masterfrom
Hamidrzash:add-scroll-padding-to-dropdown-form-field

Conversation

@Hamidrzash

@Hamidrzash Hamidrzash commented Mar 24, 2026

Copy link
Copy Markdown

Follow-up to #183109, which added scrollPadding to DropdownMenu.

DropdownMenuFormField wraps DropdownMenu but did not forward the scrollPadding parameter. This PR adds it for consistency.

Related Issues

Completes #182890

Pre-launch Checklist

@github-actions github-actions Bot added framework flutter/packages/flutter repository. See also f: labels. p: material_ui material_ui package in flutter/packages labels Mar 24, 2026
@Hamidrzash Hamidrzash mentioned this pull request Mar 24, 2026
Closed
gemini-code-assist[bot]
gemini-code-assist Bot reviewed Mar 24, 2026
View reviewed changes

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds the scrollPadding property to DropdownMenuFormField, forwarding it to the underlying DropdownMenu widget. This change aligns the form field variant with the base widget. A corresponding test has been added to verify that the property is passed correctly, checking both the default and a custom value.

Comment thread packages/flutter/lib/src/material/dropdown_menu_form_field.dart
@navaronbracke navaronbracke added the CICD Run CI/CD label Mar 24, 2026
@dkwingsmt
dkwingsmt self-requested a review March 25, 2026 18:30
@github-actions github-actions Bot removed the CICD Run CI/CD label Mar 28, 2026
dkwingsmt
dkwingsmt approved these changes Mar 31, 2026
View reviewed changes

@dkwingsmt dkwingsmt left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you!

@dkwingsmt dkwingsmt added the CICD Run CI/CD label Mar 31, 2026
@github-actions github-actions Bot removed the CICD Run CI/CD label Mar 31, 2026
@dkwingsmt dkwingsmt added autosubmit Merge PR when tree becomes green via auto submit App CICD Run CI/CD labels Mar 31, 2026
@Hamidrzash

Hamidrzash commented Apr 5, 2026

Copy link
Copy Markdown
Author

Hi @dkwingsmt the PR seems to be stuck on google testing...anything i should do?

@dkwingsmt
dkwingsmt self-requested a review April 8, 2026 18:30
@github-actions github-actions Bot removed the CICD Run CI/CD label Apr 8, 2026
@dkwingsmt dkwingsmt added the CICD Run CI/CD label Apr 8, 2026
@auto-submit auto-submit Bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Apr 8, 2026
@auto-submit

auto-submit Bot commented Apr 8, 2026

Copy link
Copy Markdown
Contributor

autosubmit label was removed for flutter/flutter/184059, because - The status or check suite Windows build_tests_3_9 has failed. Please fix the issues identified (or deflake) before re-applying this label.

@dkwingsmt

dkwingsmt commented Apr 8, 2026

Copy link
Copy Markdown
Contributor

Thanks for your contribution! This PR has reached completion, however we're not able to merge this PR for the moment due to the Material/Cupertino code freeze (#184093). As soon as the decoupling is complete, we will post a way to port this PR to the new packages to land. In the meantime, I'll convert this PR to a draft and apply a label so that we can quickly find it when the freeze is lifted.

@dkwingsmt
dkwingsmt marked this pull request as draft April 8, 2026 19:56
@dkwingsmt dkwingsmt added waiting for code freeze This PR is waiting for a code freeze to resolve. and removed CICD Run CI/CD labels Apr 8, 2026
@flutter-dashboard

flutter-dashboard Bot commented Apr 8, 2026

Copy link
Copy Markdown

This pull request has been changed to a draft. The currently pending flutter-gold status will not be able to resolve until a new commit is pushed or the change is marked ready for review again.

For more guidance, visit Writing a golden file test for package:flutter.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@Piinks Piinks added the Decoupling: Not ready to port yet Instructions will be provided when this is ready to move to flutter/packages. label Jun 24, 2026
@Piinks

Piinks commented Jun 24, 2026

Copy link
Copy Markdown
Contributor

I've marked this PR as not ready to port to flutter/packages yet.
We'll provide instructions to move this change over to material_ui/cupertino_ui once ready to receive PRs. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dkwingsmt dkwingsmt dkwingsmt approved these changes
@navaronbracke navaronbracke navaronbracke approved these changes
+1 more reviewer
@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Decoupling: Not ready to port yet Instructions will be provided when this is ready to move to flutter/packages. framework flutter/packages/flutter repository. See also f: labels. p: material_ui material_ui package in flutter/packages waiting for code freeze This PR is waiting for a code freeze to resolve.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Hamidrzash @dkwingsmt @Piinks @navaronbracke