Fix generating both `settings.gradle` and `settings.gradle.kts` for plugins by AbdeMohlbi · Pull Request #181592 · flutter/flutter

AbdeMohlbi · 2026-01-28T12:03:24Z

Fixes #181565
Fixes #142685
this was a side effect from #173993

Pre-launch Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
I signed the CLA.
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is test-exempt.
I followed the breaking change policy and added Data Driven Fixes where supported.
All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the gemini-code-assist bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.

Remove settings.gradle template from plugin_shared.

…ttings.gradle.tmpl

Add test for plugin creation with only settings.gradle.kts

Added regression test for issue flutter#181565 in create_test.dart.

gemini-code-assist

Code Review

This pull request removes the legacy Groovy-based settings.gradle.tmpl from the shared plugin template, ensuring that only the Kotlin-based settings.gradle.kts is used for new Android plugins. This is a good cleanup to align with modern Android development practices. The change is validated by a new test in create_test.dart which confirms that only the .kts file is generated. The changes are correct and improve the consistency of the plugin template. The implementation is straightforward and well-tested, and I have no further comments.

AbdeMohlbi · 2026-01-28T14:24:47Z

the tests already passed once , i did add the comment about the regression in the new test just to have the same format with other tests.

AbdeMohlbi · 2026-01-28T14:25:31Z

Code Review

This pull request removes the legacy Groovy-based settings.gradle.tmpl from the shared plugin template, ensuring that only the Kotlin-based settings.gradle.kts is used for new Android plugins. This is a good cleanup to align with modern Android development practices. The change is validated by a new test in create_test.dart which confirms that only the .kts file is generated. The changes are correct and improve the consistency of the plugin template. The implementation is straightforward and well-tested, and I have no further comments.

huh this is a first , are you okay ?

reidbaker · 2026-01-28T16:04:20Z

Manual testing includes flutter create --template=plugin --platforms=android --android-language=kotlin android_lang_kotlin and flutter create --template=plugin --platforms=android --android-language=java android_lang_java I have confirmed both run and build successfully.

Our (flutter android's) goal is to have all our generated build code in not groovy (aka in kotlin). This pr helps move us towards that even if the plugins are in java.

reidbaker · 2026-01-28T16:06:37Z

    overrides: {FeatureFlags: () => TestFeatureFlags(), Logger: () => logger},
  );

+  testUsingContext(


Is there a mechanism for these tests to clean up after themselves?

not that i know of.

is this what do you need :

flutter/packages/flutter_tools/test/commands.shard/permeable/create_test.dart

Lines 124 to 127 in 439321b

tearDownAll(() async {

await restoreFlutterToolsSnapshot();

});

yep that looks like cleanup to me we are good.

ok thanks for the quick review!

AbdeMohlbi · 2026-01-28T16:10:02Z

Manual testing includes flutter create --template=plugin --platforms=android --android-language=kotlin android_lang_kotlin and flutter create --template=plugin --platforms=android --android-language=java android_lang_java I have confirmed both run and build successfully.

Our (flutter android's) goal is to have all our generated build code in not groovy (aka in kotlin). This pr helps move us towards that even if the plugins are in java.

@reidbaker should i create other tests for rest (to confirm that flutter create --template=plugin --platforms=android --android-language=kotlin android_lang_kotlin and flutter create --template=plugin --platforms=android --android-language=java android_lang_java have the expected contents ? )?

reidbaker · 2026-01-28T16:23:47Z

Manual testing includes flutter create --template=plugin --platforms=android --android-language=kotlin android_lang_kotlin and flutter create --template=plugin --platforms=android --android-language=java android_lang_java I have confirmed both run and build successfully.
Our (flutter android's) goal is to have all our generated build code in not groovy (aka in kotlin). This pr helps move us towards that even if the plugins are in java.

@reidbaker should i create other tests for rest (to confirm that flutter create --template=plugin --platforms=android --android-language=kotlin android_lang_kotlin and flutter create --template=plugin --platforms=android --android-language=java android_lang_java have the expected contents ? )?

I think this prs test adds what this pr needs no new tests are required.

…kts` for plugins (flutter/flutter#181592)

Roll Flutter from dfd92b773219 to da72d5936d69 (39 revisions) flutter/flutter@dfd92b7...da72d59 2026-01-29 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[ Tool / Engine ] Cleanup x86 references (#181152)" (flutter/flutter#181643) 2026-01-29 [email protected] Roll Skia from 174db42b7300 to 89df65f8324c (2 revisions) (flutter/flutter#181636) 2026-01-29 [email protected] [material/menu_anchor.dart] Add animations to MenuAnchor. (flutter/flutter#176494) 2026-01-28 [email protected] Roll Skia from 8e09f8a82251 to 174db42b7300 (6 revisions) (flutter/flutter#181627) 2026-01-28 [email protected] Send statusBarTouch events via dedicated messages (flutter/flutter#179643) 2026-01-28 [email protected] test: Improve DropdownMenuFormField tests (flutter/flutter#181369) 2026-01-28 [email protected] Account for vec3 padding in Metal (flutter/flutter#181563) 2026-01-28 [email protected] [ Tool / Engine ] Cleanup x86 references (flutter/flutter#181152) 2026-01-28 [email protected] Fix the issue on macOS where, after a hot restart with multiple windows, unresponsive windows are left behind. (flutter/flutter#180287) 2026-01-28 [email protected] Roll Skia from 675444e94bc9 to 8e09f8a82251 (7 revisions) (flutter/flutter#181606) 2026-01-28 [email protected] Roll Packages from e37af11 to 1cb2148 (5 revisions) (flutter/flutter#181608) 2026-01-28 [email protected] fix: swap app and engine version in vk::ApplicationInfo (flutter/flutter#181432) 2026-01-28 [email protected] Adds impeller backend to skia gold client (flutter/flutter#181503) 2026-01-28 [email protected] Remove chrome_and_driver dependency where it's not needed (flutter/flutter#178174) 2026-01-28 [email protected] chore: Windows_mokey basic_material_app_win__compile !bringup (flutter/flutter#180985) 2026-01-28 [email protected] Fix generating both `settings.gradle` and `settings.gradle.kts` for plugins (flutter/flutter#181592) 2026-01-28 [email protected] Roll Skia from 6614f89de521 to 675444e94bc9 (3 revisions) (flutter/flutter#181587) 2026-01-28 [email protected] Fix `todayBorder` todayBorder color is incorrectly overridden by `todayForegroundColor` in CalendarDatePicker (flutter/flutter#178792) 2026-01-28 [email protected] Roll Skia from 8f1695a4b328 to 6614f89de521 (2 revisions) (flutter/flutter#181583) 2026-01-28 [email protected] feat: add RoundedSuperellipseInputBorder (flutter/flutter#177220) 2026-01-28 [email protected] Roll Dart SDK from 38e351498549 to f10dcbfca98f (2 revisions) (flutter/flutter#181582) 2026-01-28 [email protected] Roll Skia from f424d58e37a3 to 8f1695a4b328 (6 revisions) (flutter/flutter#181577) 2026-01-28 [email protected] Remove unused code paths in `PlatformViewsController.java` (flutter/flutter#181393) 2026-01-28 [email protected] feat: add onEnd to AnimatedCrossFade (flutter/flutter#181455) 2026-01-28 [email protected] Don't pass bounds to saveLayer call when painting ImageFilter (flutter/flutter#181353) 2026-01-28 [email protected] test: Clarify failure messages on gestures/debug_test.dart (flutter/flutter#181109) 2026-01-27 [email protected] Roll Fuchsia Linux SDK from akraNGn2lw4T1msgZ... to adhoq9ouVRh0xzkm3... (flutter/flutter#181571) 2026-01-27 [email protected] Roll Dart SDK from 4c7cb0a1d07d to 38e351498549 (4 revisions) (flutter/flutter#181570) 2026-01-27 [email protected] Make sure that an AnimatedPadding doesn't crash in 0x0 environment (flutter/flutter#181235) 2026-01-27 [email protected] Make sure that an ImageFiltered doesn't crash at 0x0 environment (flutter/flutter#181067) 2026-01-27 [email protected] Marks firebase_release_smoke_test to be unflaky (flutter/flutter#181308) 2026-01-27 [email protected] Fix remove material import box decoration test (flutter/flutter#181253) 2026-01-27 [email protected] Roll Skia from c2754838b077 to f424d58e37a3 (8 revisions) (flutter/flutter#181564) 2026-01-27 [email protected] Make sure that an AnimatedAlign doesn't crash in 0x0 environment (flutter/flutter#181361) 2026-01-27 [email protected] Make sure that an ImageIcon doesn't crash in 0x0 environment (flutter/flutter#181099) 2026-01-27 [email protected] Make sure that an AnimatedContainer doesn't crash in 0x0 environment (flutter/flutter#181198) 2026-01-27 [email protected] Make sure that an AnimatedRotation doesn't crash in 0x0 environment (flutter/flutter#181486) 2026-01-27 [email protected] Make sure that an AnimatedPositionedDirectional doesn't crash in 0x0 … (flutter/flutter#181451) 2026-01-27 [email protected] Merge changelog for 3.38.8. (flutter/flutter#181558) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. ...

…lugins (flutter#181592) Fixes flutter#181565 Fixes flutter#142685 this was a side effect from flutter#173993 ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.  [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md

…r#10923) Roll Flutter from dfd92b773219 to da72d5936d69 (39 revisions) flutter/flutter@dfd92b7...da72d59 2026-01-29 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[ Tool / Engine ] Cleanup x86 references (#181152)" (flutter/flutter#181643) 2026-01-29 [email protected] Roll Skia from 174db42b7300 to 89df65f8324c (2 revisions) (flutter/flutter#181636) 2026-01-29 [email protected] [material/menu_anchor.dart] Add animations to MenuAnchor. (flutter/flutter#176494) 2026-01-28 [email protected] Roll Skia from 8e09f8a82251 to 174db42b7300 (6 revisions) (flutter/flutter#181627) 2026-01-28 [email protected] Send statusBarTouch events via dedicated messages (flutter/flutter#179643) 2026-01-28 [email protected] test: Improve DropdownMenuFormField tests (flutter/flutter#181369) 2026-01-28 [email protected] Account for vec3 padding in Metal (flutter/flutter#181563) 2026-01-28 [email protected] [ Tool / Engine ] Cleanup x86 references (flutter/flutter#181152) 2026-01-28 [email protected] Fix the issue on macOS where, after a hot restart with multiple windows, unresponsive windows are left behind. (flutter/flutter#180287) 2026-01-28 [email protected] Roll Skia from 675444e94bc9 to 8e09f8a82251 (7 revisions) (flutter/flutter#181606) 2026-01-28 [email protected] Roll Packages from e37af11 to 1cb2148 (5 revisions) (flutter/flutter#181608) 2026-01-28 [email protected] fix: swap app and engine version in vk::ApplicationInfo (flutter/flutter#181432) 2026-01-28 [email protected] Adds impeller backend to skia gold client (flutter/flutter#181503) 2026-01-28 [email protected] Remove chrome_and_driver dependency where it's not needed (flutter/flutter#178174) 2026-01-28 [email protected] chore: Windows_mokey basic_material_app_win__compile !bringup (flutter/flutter#180985) 2026-01-28 [email protected] Fix generating both `settings.gradle` and `settings.gradle.kts` for plugins (flutter/flutter#181592) 2026-01-28 [email protected] Roll Skia from 6614f89de521 to 675444e94bc9 (3 revisions) (flutter/flutter#181587) 2026-01-28 [email protected] Fix `todayBorder` todayBorder color is incorrectly overridden by `todayForegroundColor` in CalendarDatePicker (flutter/flutter#178792) 2026-01-28 [email protected] Roll Skia from 8f1695a4b328 to 6614f89de521 (2 revisions) (flutter/flutter#181583) 2026-01-28 [email protected] feat: add RoundedSuperellipseInputBorder (flutter/flutter#177220) 2026-01-28 [email protected] Roll Dart SDK from 38e351498549 to f10dcbfca98f (2 revisions) (flutter/flutter#181582) 2026-01-28 [email protected] Roll Skia from f424d58e37a3 to 8f1695a4b328 (6 revisions) (flutter/flutter#181577) 2026-01-28 [email protected] Remove unused code paths in `PlatformViewsController.java` (flutter/flutter#181393) 2026-01-28 [email protected] feat: add onEnd to AnimatedCrossFade (flutter/flutter#181455) 2026-01-28 [email protected] Don't pass bounds to saveLayer call when painting ImageFilter (flutter/flutter#181353) 2026-01-28 [email protected] test: Clarify failure messages on gestures/debug_test.dart (flutter/flutter#181109) 2026-01-27 [email protected] Roll Fuchsia Linux SDK from akraNGn2lw4T1msgZ... to adhoq9ouVRh0xzkm3... (flutter/flutter#181571) 2026-01-27 [email protected] Roll Dart SDK from 4c7cb0a1d07d to 38e351498549 (4 revisions) (flutter/flutter#181570) 2026-01-27 [email protected] Make sure that an AnimatedPadding doesn't crash in 0x0 environment (flutter/flutter#181235) 2026-01-27 [email protected] Make sure that an ImageFiltered doesn't crash at 0x0 environment (flutter/flutter#181067) 2026-01-27 [email protected] Marks firebase_release_smoke_test to be unflaky (flutter/flutter#181308) 2026-01-27 [email protected] Fix remove material import box decoration test (flutter/flutter#181253) 2026-01-27 [email protected] Roll Skia from c2754838b077 to f424d58e37a3 (8 revisions) (flutter/flutter#181564) 2026-01-27 [email protected] Make sure that an AnimatedAlign doesn't crash in 0x0 environment (flutter/flutter#181361) 2026-01-27 [email protected] Make sure that an ImageIcon doesn't crash in 0x0 environment (flutter/flutter#181099) 2026-01-27 [email protected] Make sure that an AnimatedContainer doesn't crash in 0x0 environment (flutter/flutter#181198) 2026-01-27 [email protected] Make sure that an AnimatedRotation doesn't crash in 0x0 environment (flutter/flutter#181486) 2026-01-27 [email protected] Make sure that an AnimatedPositionedDirectional doesn't crash in 0x0 … (flutter/flutter#181451) 2026-01-27 [email protected] Merge changelog for 3.38.8. (flutter/flutter#181558) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. ...

Remove settings.gradle from plugin_shared templates

1ea336f

Remove settings.gradle template from plugin_shared.

github-actions Bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Jan 28, 2026

Delete packages/flutter_tools/templates/plugin_shared/android.tmpl/se…

d058b07

…ttings.gradle.tmpl

github-actions Bot added the team-android Owned by Android platform team label Jan 28, 2026

Implement test for plugin with settings.gradle.kts

c4cce8e

Add test for plugin creation with only settings.gradle.kts

AbdeMohlbi marked this pull request as ready for review January 28, 2026 14:18

AbdeMohlbi requested a review from a team as a code owner January 28, 2026 14:18

Add regression test for plugin settings

88767c6

Added regression test for issue flutter#181565 in create_test.dart.

gemini-code-assist Bot reviewed Jan 28, 2026

View reviewed changes

AbdeMohlbi changed the title ~~WIP~~ Fix generating both settings.gradle and settings.gradle.kts for plugins Jan 28, 2026

format ):

038174d

reidbaker approved these changes Jan 28, 2026

View reviewed changes

reidbaker added the autosubmit Merge PR when tree becomes green via auto submit App label Jan 28, 2026

reidbaker reviewed Jan 28, 2026

View reviewed changes

auto-submit Bot added this pull request to the merge queue Jan 28, 2026

Merged via the queue into flutter:master with commit 0bd69d2 Jan 28, 2026
144 checks passed

flutter-dashboard Bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jan 28, 2026

engine-flutter-autoroll mentioned this pull request Jan 28, 2026

Roll Flutter from dfd92b773219 to 0bd69d2084fc (24 revisions) flutter/packages#10917

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 28, 2026

0bd69d208 Fix generating both settings.gradle and `settings.gradle.…

fba2c2c

…kts` for plugins (flutter/flutter#181592)

engine-flutter-autoroll mentioned this pull request Jan 28, 2026

Roll Flutter from dfd92b773219 to 2260544e148b (25 revisions) flutter/packages#10918

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 28, 2026

0bd69d208 Fix generating both settings.gradle and `settings.gradle.…

6c117e3

…kts` for plugins (flutter/flutter#181592)

engine-flutter-autoroll mentioned this pull request Jan 28, 2026

Roll Flutter from dfd92b773219 to 0c2d316b1565 (27 revisions) flutter/packages#10919

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 28, 2026

0bd69d208 Fix generating both settings.gradle and `settings.gradle.…

1a2ac29

…kts` for plugins (flutter/flutter#181592)

engine-flutter-autoroll mentioned this pull request Jan 29, 2026

Roll Flutter from dfd92b773219 to da72d5936d69 (39 revisions) flutter/packages#10923

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 29, 2026

0bd69d208 Fix generating both settings.gradle and `settings.gradle.…

b46c788

…kts` for plugins (flutter/flutter#181592)

Navigation Menu

Uh oh!

Fix generating both `settings.gradle` and `settings.gradle.kts` for plugins - #181592

Fix generating both `settings.gradle` and `settings.gradle.kts` for plugins#181592
auto-submit[bot] merged 5 commits into
flutter:masterfrom
AbdeMohlbi:issue_181565_take_2

AbdeMohlbi commented Jan 28, 2026 •

edited

Loading

Uh oh!

gemini-code-assist Bot left a comment

Uh oh!

AbdeMohlbi commented Jan 28, 2026

Uh oh!

AbdeMohlbi commented Jan 28, 2026

Code Review

Uh oh!

reidbaker commented Jan 28, 2026

Uh oh!

reidbaker Jan 28, 2026

Uh oh!

AbdeMohlbi Jan 28, 2026

Uh oh!

AbdeMohlbi Jan 28, 2026

Uh oh!

reidbaker Jan 28, 2026

Uh oh!

AbdeMohlbi Jan 28, 2026

Uh oh!

AbdeMohlbi commented Jan 28, 2026 •

edited

Loading

Uh oh!

reidbaker commented Jan 28, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants


	tearDownAll(() async {
	await restoreFlutterToolsSnapshot();
	});

Uh oh!

Conversation

AbdeMohlbi commented Jan 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pre-launch Checklist

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

AbdeMohlbi commented Jan 28, 2026

Uh oh!

AbdeMohlbi commented Jan 28, 2026

Code Review

Uh oh!

reidbaker commented Jan 28, 2026

Uh oh!

reidbaker Jan 28, 2026

Choose a reason for hiding this comment

Uh oh!

AbdeMohlbi Jan 28, 2026

Choose a reason for hiding this comment

Uh oh!

AbdeMohlbi Jan 28, 2026

Choose a reason for hiding this comment

Uh oh!

reidbaker Jan 28, 2026

Choose a reason for hiding this comment

Uh oh!

AbdeMohlbi Jan 28, 2026

Choose a reason for hiding this comment

Uh oh!

AbdeMohlbi commented Jan 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

reidbaker commented Jan 28, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

AbdeMohlbi commented Jan 28, 2026 •

edited

Loading

AbdeMohlbi commented Jan 28, 2026 •

edited

Loading