Skip to content

Account for vec3 padding in Metal #181563

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
auto-submit merged 20 commits into from
Jan 28, 2026
Merged

Account for vec3 padding in Metal #181563

Changes from 1 commit
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
afd5386
Reenabled metal uniform array test by fixing metal padding
gaaclarke Jan 22, 2026
6f31d9c
disabled compiler tests again, will follow up
gaaclarke Jan 22, 2026
1a223c3
renamed EmplaceVulkanUniform
gaaclarke Jan 22, 2026
32678fd
trimmed generated comments
gaaclarke Jan 22, 2026
da9c5c7
renamed struct_layout to padding_layout to better match what it used for
gaaclarke Jan 22, 2026
686d632
revert compiler test
gaaclarke Jan 22, 2026
89cef18
Revert "revert compiler test"
gaaclarke Jan 22, 2026
bc33acc
revert some mat2 changes
gaaclarke Jan 22, 2026
b277883
rolled up array padding layout
gaaclarke Jan 23, 2026
4ad9fc9
renamed flatbuffer field
gaaclarke Jan 23, 2026
98c1785
removed dead code
gaaclarke Jan 23, 2026
0c8de5d
bluk feedback
gaaclarke Jan 23, 2026
f20fbb5
wally feedback
gaaclarke Jan 23, 2026
22c3665
bluk2
gaaclarke Jan 23, 2026
66933a0
getsize tweak
gaaclarke Jan 24, 2026
964aabb
updated test to test gpu size, dart size isn't used for vulkan
gaaclarke Jan 26, 2026
fb98434
Fix getDartSize function
walley892 Jan 27, 2026
9f5ea0b
bump flatbuffer version
walley892 Jan 27, 2026
7ecb72c
reenable test for all platforms
walley892 Jan 27, 2026
5f77232
Merge remote-tracking branch 'upstream/master' into metal-vec3-padding
walley892 Jan 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Revert "revert compiler test" 
This reverts commit 686d632.
  • Loading branch information
@gaaclarke
gaaclarke committed Jan 22, 2026
commit 89cef184de21c39d5957838e6bd79f50c248f416
9 changes: 7 additions & 2 deletions engine/src/flutter/impeller/compiler/compiler_unittests.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -438,8 +438,13 @@ TEST_P(CompilerTestRuntime, Mat2Reflection) {
EXPECT_EQ(mat2Member["size"], 8u);

// Byte length should be total array size (stride * count)
// Stride 16 * 2 = 32.
EXPECT_EQ(mat2Member["byte_length"], 32u);
// Metal: Stride 8 * 2 = 16.
// Other: Stride 16 * 2 = 32.
if (TargetPlatformIsMetal(GetParam())) {
EXPECT_EQ(mat2Member["byte_length"], 16u);
} else {
EXPECT_EQ(mat2Member["byte_length"], 32u);
}

// Array elements should be 2 (columns).
EXPECT_EQ(mat2Member["array_elements"], 2u);
Expand Down