Skip to content

Add alignment to SizeTransition #177895

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
auto-submit merged 21 commits into from
Jan 26, 2026
Merged

Add alignment to SizeTransition #177895

Changes from 1 commit
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
1597795
Add alignment and remove axisAlignment
IvoneDjaja Nov 2, 2025
7102329
Fix breaking change
IvoneDjaja Nov 2, 2025
af78c39
Fix test
IvoneDjaja Nov 2, 2025
83f6762
Use AlignmentDirectional and fix documentation
IvoneDjaja Nov 3, 2025
88013b0
Revert "Add alignment and remove axisAlignment"
IvoneDjaja Nov 18, 2025
b57c42b
Add alignment and deprecate axisAlignment
IvoneDjaja Nov 18, 2025
4596a85
Add test
IvoneDjaja Nov 20, 2025
e16e2bd
Add dart fix
IvoneDjaja Nov 20, 2025
57a487c
Add dart fix test
IvoneDjaja Nov 20, 2025
c603672
Fix deprecation message
IvoneDjaja Nov 22, 2025
167622a
Fix deprecation message
IvoneDjaja Nov 22, 2025
0a934b4
Fix missing dot in deprecation message version
IvoneDjaja Nov 26, 2025
a8c2768
Fix trailing number in deprecation message version
IvoneDjaja Dec 8, 2025
bb6420e
Fix format
IvoneDjaja Dec 8, 2025
fa62c6b
Fix format ad info log
IvoneDjaja Dec 8, 2025
e7cb38d
Add documentation
IvoneDjaja Dec 24, 2025
bc1de93
Add test
IvoneDjaja Dec 24, 2025
5d4a729
Format test
IvoneDjaja Dec 24, 2025
45eaa51
Format test
IvoneDjaja Jan 8, 2026
936e293
Fix doc
IvoneDjaja Jan 16, 2026
2e87eb3
Fix doc
IvoneDjaja Jan 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix deprecation message
  • Loading branch information
@IvoneDjaja
IvoneDjaja committed Jan 26, 2026
commit 167622add0cbe560509c84c7ac095dd50bcad90e
4 changes: 2 additions & 2 deletions packages/flutter/lib/src/widgets/transitions.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -453,7 +453,7 @@ class SizeTransition extends AnimatedWidget {
required Animation<double> sizeFactor,
@Deprecated(

@reidbaker reidbaker Nov 24, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Analysis errors appear to be formatting of this file.

git apply <<DONE
diff --git a/packages/flutter/lib/src/widgets/transitions.dart b/packages/flutter/lib/src/widgets/transitions.dart
index 346a94648b8..00000000000 100644
--- a/packages/flutter/lib/src/widgets/transitions.dart
+++ b/packages/flutter/lib/src/widgets/transitions.dart
@@ -454,7 +454,8 @@ class SizeTransition extends AnimatedWidget {
     @Deprecated(
       'Use alignment instead. '
       'This feature was deprecated after v3.38.0-1.0.pre-716',
-    ) this.axisAlignment,
+    )
+    this.axisAlignment,
     this.alignment,
     this.fixedCrossAxisSizeFactor,
     this.child,
@@ -1254,3 +1255,4 @@ class AnimatedBuilder extends ListenableBuilder {
   @override
   TransitionBuilder get builder => super.builder;
 }
diff --git a/packages/flutter/test_fixes/widgets/transitions.dart b/packages/flutter/test_fixes/widgets/transitions.dart
index 9e73b4584bb..00000000000 100644
--- a/packages/flutter/test_fixes/widgets/transitions.dart
+++ b/packages/flutter/test_fixes/widgets/transitions.dart
@@ -5,6 +5,10 @@ void main() {
   SizeTransition();
   SizeTransition(axisAlignment: 1.0);
   SizeTransition(axis: Axis.vertical, axisAlignment: 1.0);
-  SizeTransition(axis: Axis.vertical, axisAlignment: position.dx < 0 ? 1.0 : -1.0);
+  SizeTransition(
+    axis: Axis.vertical,
+    axisAlignment: position.dx < 0 ? 1.0 : -1.0,
+  );
   SizeTransition(axis: Axis.horizontal, axisAlignment: 1.0);
 }
DONE

@IvoneDjaja IvoneDjaja Dec 23, 2025

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @reidbaker, I fixed the 2 formatting issues here:
Fix deprecation message
Fix format

'Use alignment instead. '
'This feature was deprecated after v3.38.0-1.0.pre-681',
'This feature was deprecated after v3.38.0-1.0.pre-716',
) this.axisAlignment,
this.alignment,
this.fixedCrossAxisSizeFactor,
Expand Down Expand Up @@ -489,7 +489,7 @@ class SizeTransition extends AnimatedWidget {
/// A value of 0.0 (the default) indicates the center for either [axis] value.

@dkwingsmt dkwingsmt Dec 17, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add something like "This property has been deprecated and superseded by [alignment]. Existing usages can be migrated to [alignment] as ... ".

(A brief migration guide might not be required here, although I think it'll be a good idea unless it's very complicated.)

@IvoneDjaja IvoneDjaja Dec 24, 2025

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add documentation

@Deprecated(
'Use alignment instead. '
'This feature was deprecated after v3.38.0-1.0.pre-681',
'This feature was deprecated after v3.38.0-1.0.pre-716',
)
final double? axisAlignment;

Expand Down