Bump minSdk to 24 in engine - #175508

@gmackall I want you to look at the places where we throw and api exception and decide if you agree we should remove those or not.

autosubmit label was removed for flutter/flutter/175508, because - The status or check suite Google testing has failed. Please fix the issues identified (or deflake) before re-applying this label.

This will take work from a googler. There are some tests that are failing because they assume the min is api 23 not 24.

the Linux flutter_plugins is unrelated ,error:

Analyzing google_maps_flutter_web...

  error - example/integration_test/overlay_test.dart:44:31 - A value of type 'Size?' can't be assigned to a variable of type 'Size'. Try changing the type of the variable, or casting the right-hand type to 'Size'. - invalid_assignment```  

It looks like this pull request may not have tests. Please make sure to add tests or get an explicit test exemption before merging.

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. If you believe this PR qualifies for a test exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group.

Not sure why the google testing wasn't running automatically, lets see if it works now

This looks good to go. May I add the autosubmit tag?

@chinmaygarde I thought this required a g3 cl to land this. I dont see google testing running against this pr.

There were failures related to this pr that were needed in g3.

Oh, I figured that was already done since all checks were green.

I manually kicked off a google testing pass that is now running.

@AbdeMohlbi FYI @ash2moon is working on the g3 fix for this pr. Nothing you can do until he is done. Wanted to make sure you knew the team is actively working on getting this landed.

@AbdeMohlbi FYI @ash2moon is working on the g3 fix for this pr. Nothing you can do until he is done. Wanted to make sure you knew the team is actively working on getting this landed.

Noted ✅

I'm not sure why Google Testing didn't kick off on the last merge, I'm going to mark this as "request changes" until we get this resolved on the Google testing side so this doesn't accidentally get merged and need to be reverted post-submit. @AbdeMohlbi thank you so much for your patience!

no issue thank u for the info , i'm not sure but it may be related , smth simular happend in another PR where i was not a member at the time when that PR was created then when i became a member , google testing didn't kick off as usual maybe it's the same issue.

Update from our side @ash2moon is working on migrating google apps. I didnt realize the number that had not migrated and some of those apps have policies around minimum api level bumping that we are working through. This pr will need to sit until that work is done. Probably at least a couple of weeks.

For some reason analyze_dart_ui is failing with a timeout https://ci.chromium.org/ui/p/flutter/builders/try/Linux%20Engine%20Drone/3791344/overview

For some reason analyze_dart_ui is failing with a timeout https://ci.chromium.org/ui/p/flutter/builders/try/Linux%20Engine%20Drone/3791344/overview

When was the last time this was synced. I did a rollback of a commit last night that had something similar for: https://ci.chromium.org/ui/p/flutter/builders/prod/Linux%20Production%20Engine%20Drone/1375083/overview

For some reason analyze_dart_ui is failing with a timeout https://ci.chromium.org/ui/p/flutter/builders/try/Linux%20Engine%20Drone/3791344/overview

When was the last time this was synced. I did a rollback of a commit last night that had something similar for: https://ci.chromium.org/ui/p/flutter/builders/prod/Linux%20Production%20Engine%20Drone/1375083/overview

2 days ago, will sync and try again.