feat(rc): Add Remote Config Management API #502
Merged
lahirumaramba merged 14 commits intomasterfrom Dec 14, 2020
Merged
Conversation
- Add initial classes for Remote Config API - Add unit tests
* Add the entry point for Remote Config * Remove the builder in RemoteConfig.java * Remove fromApp and use the constructor directly * Fix doc strings
- Introduce Response Types and Public Types - Implement toResponseType() and toPublicType() - Add parameters to RemoteConfigTemplate - Add unit tests
* Refactor Public and Response types * reformat code * Clean up code style * Remove getUseInAppDefault and use the value type in setter
* Add Remote Config conditions to template
* Introduce Parameter Groups * Refactor unit tests * PR fixes * Fix variable names in unit tests
* Add Version information to RC template * PR fixes * PR fixes * Clean up template unit tests
…ns (#496) * Add Pubish, Validate, and GetTemplateAtVersion operations * Clean up tests * Move PublishOptions to parent package
* Add Remote Config rollback operation * PR fixes
* Add List Versions operation in Remote Config * PR fixes * Move convertToUtcZuluFormat to utils class
* Add toJSON and fromJSON to Remote Config Template
* Add Remote Config Integration tests * Updated listversions tests to use the sync apis
egilmorez
reviewed
Dec 11, 2020
Contributor
egilmorez
left a comment
egilmorez
left a comment
There was a problem hiding this comment.
Thanks Lahiru! A few questions and things.
src/main/java/com/google/firebase/remoteconfig/FirebaseRemoteConfig.java
Outdated
Show resolved
Hide resolved
src/main/java/com/google/firebase/remoteconfig/FirebaseRemoteConfig.java
Show resolved
Hide resolved
src/main/java/com/google/firebase/remoteconfig/FirebaseRemoteConfig.java
Show resolved
Hide resolved
src/main/java/com/google/firebase/remoteconfig/FirebaseRemoteConfig.java
Outdated
Show resolved
Hide resolved
src/main/java/com/google/firebase/remoteconfig/FirebaseRemoteConfig.java
Show resolved
Hide resolved
src/main/java/com/google/firebase/remoteconfig/FirebaseRemoteConfig.java
Outdated
Show resolved
Hide resolved
src/main/java/com/google/firebase/remoteconfig/ListVersionsPage.java
Outdated
Show resolved
Hide resolved
Member
Author
|
Thank you, @egilmorez ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RELEASE NOTES: Added support for the Remote Config API. This API enables Firebase developers to programmatically manage the set of JSON-formatted parameters and conditions known as the Remote Config template.
Resolves: #446