Add Remote Config Integration tests#501
Merged
lahirumaramba merged 2 commits intoremote-configfrom Dec 11, 2020
Merged
Conversation
hiranya911
approved these changes
Dec 11, 2020
Contributor
hiranya911
left a comment
hiranya911
left a comment
There was a problem hiding this comment.
LGTM with some suggestions.
| } | ||
|
|
||
| @Test | ||
| public void testListVersions() throws Exception { |
Contributor
There was a problem hiding this comment.
I'd suggest using the sync APIs here like the previous test case.
Member
Author
There was a problem hiding this comment.
Updated to use the sync api
| } | ||
|
|
||
| @Test | ||
| public void testTemplateOperations() throws FirebaseRemoteConfigException { |
Contributor
There was a problem hiding this comment.
Nit: Some of these can be split into separate test case with a bit of effort and extra RPCs (I'll leave it to you to decide whether that's worth it)
- validate can be easily turned into a separate test case
- getAtVersion and rollback can also be made into separate test cases if we are willing to run a few extra get and publish operations.
Member
Author
There was a problem hiding this comment.
Good point! As discussed offline let's address this in a future PR. Thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note: Added
release:stageto trigger integration testsRelated to: #446