Add List Versions operation in Remote Config#498
Merged
lahirumaramba merged 3 commits intoremote-configfrom Dec 2, 2020
Merged
Add List Versions operation in Remote Config#498lahirumaramba merged 3 commits intoremote-configfrom
lahirumaramba merged 3 commits intoremote-configfrom
Conversation
Member
Author
|
|
lahirumaramba
force-pushed
the
lm-rc-rollback-listversions
branch
2 times, most recently
from
460d914 to
180f8f9
Compare
lahirumaramba
force-pushed
the
lm-rc-rollback-listversions
branch
from
180f8f9 to
c965c48
Compare
hiranya911
suggested changes
Dec 2, 2020
Contributor
hiranya911
left a comment
hiranya911
left a comment
There was a problem hiding this comment.
Looks pretty good. Just a few thoughts on improving the implementation.
src/main/java/com/google/firebase/remoteconfig/ListVersionsOptions.java
Outdated
Show resolved
Hide resolved
src/main/java/com/google/firebase/remoteconfig/ListVersionsOptions.java
Outdated
Show resolved
Hide resolved
src/main/java/com/google/firebase/remoteconfig/ListVersionsResult.java
Outdated
Show resolved
Hide resolved
src/test/java/com/google/firebase/remoteconfig/FirebaseRemoteConfigClientImplTest.java
Outdated
Show resolved
Hide resolved
src/main/java/com/google/firebase/remoteconfig/ListVersionsOptions.java
Outdated
Show resolved
Hide resolved
src/test/java/com/google/firebase/remoteconfig/ListVersionsResultTest.java
Outdated
Show resolved
Hide resolved
hiranya911
approved these changes
Dec 2, 2020
Contributor
hiranya911
left a comment
hiranya911
left a comment
There was a problem hiding this comment.
Thanks! LGTM with a suggestion.
| return this; | ||
| } | ||
|
|
||
| private String convertToUtcZuluFormat(long millis) { |
Contributor
There was a problem hiding this comment.
Probably belongs in the shared util. I assume there are other places where this is needed.
Member
Author
There was a problem hiding this comment.
Good call. Currently, we use it only in ListVersionsOptions. I moved it to Utils anyway to future proof :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ListVersionsOptions,ListVersionsResulttypesRelated to #446