Fix Arg.all() after #30 + add more tests + small refactor - #43
Merged
Conversation
Owner
|
Great work! I made a single comment. |
Contributor
Author
|
@ffMathy I don't see any comments |
ffMathy
requested changes
Apr 29, 2019
Owner
|
Oh wow, forgot to hit "submit review". |
Owner
|
Thank you so much for this! |
Contributor
Author
|
No problem! |
Owner
|
Very cool! It's very appreciated. Perhaps I can put you as an official collaborator when I see some more PRs 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @ffMathy ;)
Today I've noticed that after #30
Arg.all()stops working when number of arguments is greater than 1.For e.g. [Arg.all()] and [1,2] second iteration returns false.
With min is also not correct because [1,2] and [1,2,3] return true.
I've added
in
areArgumentArraysEqualRest changes:
I hope you will enjoy it ;)
Regards!
CC: @domasx2