Refac function argument recording. fixes #25, #23 - #30
Merged
ffMathy merged 2 commits intoMar 24, 2019
Conversation
Closed
Contributor
Author
|
I'd omit build output from git repo, instead adding |
Owner
|
Very impressive! |
Karql
added a commit
to Karql/FluffySpoon.JavaScript.Testing.Faking
that referenced
this pull request
Apr 24, 2019
ffMathy
pushed a commit
that referenced
this pull request
Apr 29, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, as promised:
This PR fixes #25 (mine) and #23 (I couldn't leave a test failing :P)
The main change here is that now there's only one
FunctionStateper property, and it records arguments for every call. Call verification is done by checking if and how many calls match the arguments inreceived()check.For bonus points, added support for methods with optional parameters :)
This PR also opens an easy path to implement call order verification & argument capturing