Automatically detect VLLEs in BinaryPhaseDiagram#341
Merged
Conversation
71f5c5e to
ba78610
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I accidentally pushed this to main already...
The PR improves the calculations of binary VLE phase diagrams by automatically checking for a liquid-liquid split.
One way to do that would be to track the stability of the liquid phase. I tested this approach and it works like a charm, however, it also increases the computation time for every phase diagram a lot. Therefore, the implemented method instead first simply calculates the entire phase diagram and then checks whether the dew line crosses itself at some point which is a clear indication of a liquid/liquid split. If it detects an intersection, a initial guess for the VLLE is interpolated from the phase diagram, which is then used to solve the actual VLLE. The liquid compositions of the VLLE are then used to calculate a new phase diagram that does not penetrate the unstable region.