Skip to content

Proper implementation of cubic equations of state #250

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
g-bauer wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

Proper implementation of cubic equations of state #250

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ed4d907
started impl for more generic cubic EoSs
g-bauer May 23, 2024
cd5cfbe
added several alpha functions
g-bauer Jun 7, 2024
e44d857
fixed typo
g-bauer Jun 7, 2024
9b5df64
fixed bug in subset method
g-bauer Jun 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fixed typo
  • Loading branch information
@g-bauer
g-bauer committed Jun 7, 2024
commit e44d857ffdf09068a7a39106cebd796abadb3afa
2 changes: 0 additions & 2 deletions feos-core/src/cubic.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -200,8 +200,6 @@ impl Residual for PengRobinson {
// Helmholtz energy
let n = state.moles.sum();
let v = state.volume;
dbg!(&b);
dbg!(&ak_mix);
n * ((v / (v - b * n)).ln()
- ak_mix / (b * SQRT_2 * 2.0 * state.temperature)
* ((v + b * n * (1.0 + SQRT_2)) / (v + b * n * (1.0 - SQRT_2))).ln())
Expand Down
2 changes: 1 addition & 1 deletion src/cubic/python.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ impl PyAlpha {
/// using
/// $m_\text{RK} = 0.480 + 1.574 \omega - 0.176 \omega^2$
#[staticmethod]
fn redlich_kwing1972() -> Self {
fn redlich_kwong1972() -> Self {
Self(RedlichKwong1972.into())
}

Expand Down