[dbsp] Disable metadata exchange in non-root circuits. #5410
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Metadata exchange + balancer add an extra round of communication to each step. Since we don't support balanced joins in the root circuit, this part can be optimized away. Signed-off-by: Leonid Ryzhyk <[email protected]>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR optimizes the dynamic scheduler by disabling metadata exchange and balancer operations in non-root circuits. Since balanced joins are not supported in non-root circuits, these operations add unnecessary communication overhead that can be eliminated.
Changes:
- Added
root_scope()checks to conditionally skip balancer operations in non-root circuits - Modified
exchange_metadatato early-return for non-root circuits, preventing metadata broadcast - Guarded all six balancer method calls with
root_scope() == 0checks
Comment on lines
+522
to
+524
| } | ||
| } | ||
| if circuit.root_scope() == 0 { |
There was a problem hiding this comment.
The two consecutive if circuit.root_scope() == 0 blocks at lines 520-523 and 524-526 could be consolidated into a single block for better readability and maintainability. Consider combining them to reduce code duplication of the condition check.
Suggested change
| } | |
| } | |
| if circuit.root_scope() == 0 { | |
| circuit.balancer().start_step(); | |
| } | |
| } else if circuit.root_scope() == 0 { |
gz
approved these changes
Jan 11, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Metadata exchange + balancer add an extra round of communication to each step. Since we don't support balanced joins in non-root circuits, this part can be optimized away.