demo: cleanup demos except packaged ones #5403
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All demos except the packages ones are removed. Maintenance of demos has historically been difficult, because demos: (1) typically have complicated setups involving many data sources and sinks, and (2) have steps specific to their use case. Both of these make it a challenge to automate running them, and for other developers to setup and debug. If any of them need to be preserved, I would suggest moving them to a separate repository. The following are removed: - Docker Compose scripts of the demos - TikTok benchmark (it depended on a demo) - The `simple-count` demo - The `project_...` demos. The references in the documentation have been removed. - The `docs-demo` demo Signed-off-by: Simon Kassing <[email protected]>
Contributor
|
Let's see if the people who created some of them want to salvage some. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All demos except the packages ones are removed. Maintenance of demos has historically been difficult, because demos: (1) typically have complicated setups involving many data sources and sinks, and (2) have steps specific to their use case. Both of these make it a challenge to automate running them, and for other developers to setup and debug.
If any of them need to be preserved, I would suggest moving them to a separate repository.
The following are removed:
simple-countdemoproject_...demos. The references in the documentation have been removed.docs-demodemoPR information