py: fix minio credentials #5367
Merged
+6
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes a regresssion with the default minio credentials for the CI. Signed-off-by: Abhinav Gyawali <[email protected]>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a regression in the default MinIO credentials used for CI testing. The changes update the MinIO configuration to use environment variables with new default values that align with the CI environment setup.
Key Changes:
- Updated default MinIO endpoint from localhost to cluster-internal DNS
- Changed default credentials from 'minioadmin'/'minioadmin' to 'minio'/'miniopasswd'
- Made all MinIO configuration values configurable via environment variables
Comments suppressed due to low confidence (1)
python/tests/platform/test_checkpoint_sync.py:1
- Corrected spelling of 'regresssion' to 'regression' in PR description.
import os
swanandx
approved these changes
Jan 3, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a regresssion with the default minio credentials for the CI.