WIP: Concurrent encoders #5361
Draft
WIP: Concurrent encoders #5361
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In preparation for adding support for parallel encoding, wrap the batch passed to `Encoder::encode` in `Arc`, so it can later be cloned and sent to multiple workers. Signed-off-by: Leonid Ryzhyk <[email protected]>
Extend trait SerBatchReader two support parallel encoders: - SerBatchReader::partition_keys - partitions the batch into approximately equal sized chunks. - SerCursor::seek_key_exact - can be used to move the cursor to the start of a partition. - SerCursor::key() - can be used to compare the current key under the cursor with the end of the partition to stop iteration. Signed-off-by: Leonid Ryzhyk <[email protected]>
All batches are now Send and Sync, so we eliminate the SyncSerBatchReader trait and add Send + Sync bounds to SerBatchReader. Signed-off-by: Leonid Ryzhyk <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#5340