pipeline-manager: pipeline_template in config #5356
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds support for users to specify a custom pipeline template name in the runtime configuration. The template is expected to be stored in a Kubernetes ConfigMap and will be used instead of the default template when deploying pipelines as StatefulSets.
- Adds a new optional
pipeline_template_namefield toRuntimeConfig - Updates all instantiations of
RuntimeConfigto include the new field set toNone - Propagates the field through the controller initialization
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| crates/feldera-types/src/config.rs | Adds pipeline_template_name field to RuntimeConfig struct with documentation and updates Default implementation |
| crates/pipeline-manager/src/db/test.rs | Updates test helper function to include pipeline_template_name: None in runtime config construction |
| crates/pipeline-manager/src/api/examples.rs | Updates example pipeline descriptor to include pipeline_template_name: None |
| crates/adapters/src/controller.rs | Propagates pipeline_template_name from global config to controller initialization |
swanandx
force-pushed
the
pipeline-template-config
branch
from
e861090 to
3c3ec93
Compare
swanandx
force-pushed
the
pipeline-template-config
branch
from
3c3ec93 to
f0430eb
Compare
abhizer
approved these changes
Jan 1, 2026
swanandx
force-pushed
the
pipeline-template-config
branch
from
f0430eb to
b8e395f
Compare
lalithsuresh
reviewed
Jan 2, 2026
swanandx
force-pushed
the
pipeline-template-config
branch
2 times, most recently
from
1ed291d to
a6b304f
Compare
lalithsuresh
reviewed
Jan 2, 2026
lalithsuresh
reviewed
Jan 2, 2026
swanandx
force-pushed
the
pipeline-template-config
branch
2 times, most recently
from
2cbef6d to
849eacd
Compare
swanandx
changed the title
swanandx
force-pushed
the
pipeline-template-config
branch
from
849eacd to
e54ab0d
Compare
lalithsuresh
approved these changes
Jan 5, 2026
snkas
approved these changes
Jan 5, 2026
Allow pipelines to specify a ConfigMap name and key in their config, which holds the StatefulSet template used for pipeline deployment Signed-off-by: Swanand Mulay <[email protected]>
swanandx
force-pushed
the
pipeline-template-config
branch
from
e54ab0d to
326597e
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
allow users to specify custom pipeline template to be used for statefulset
Checklist
Breaking Changes?
Optional field in config, should not be breaking change