[SQL] Use correct type for the connector_metadata variable (&VARIANT) #5353
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mihai Budiu <[email protected]>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes issue #5350 by correcting the type handling of the connector_metadata variable from VARIANT to &VARIANT (a reference type). The change ensures proper type consistency when the CONNECTOR_METADATA() function is used in SQL table definitions.
Key changes:
- Updated the return type transform for
CONNECTOR_METADATA()fromTO_NULLABLEtoFORCE_NULLABLE - Changed the
connector_metadatavariable type to use a reference (&VARIANT) instead of a direct value - Modified expression handling to dereference and clone when replacing
CONNECTOR_METADATA()calls
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| CatalogTests.java | Added regression test for issue #5350 validating VARIANT type handling with CONNECTOR_METADATA() |
| CustomFunctions.java | Changed return type transform from TO_NULLABLE to FORCE_NULLABLE for CONNECTOR_METADATA function |
| ToRustInnerVisitor.java | Updated variable type to reference (&VARIANT) and modified expression replacement to use deref().applyClone() |
ryzhyk
approved these changes
Dec 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5350