Fix pinned 'top nodes' tooltip not updated when choosing another metric #5348
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Karakatiza666
force-pushed
the
profiler-fixes
branch
from
19c8af6 to
98f0d22
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a UX issue where the pinned 'top nodes' tooltip would not update when the user selected a different metric. The solution refactors the tooltip refresh mechanism to automatically update when metadata changes, and simplifies the API by removing the metric parameter from showTopNodes() since the metric is now selected separately.
Key Changes:
- Introduced a tooltip refresh callback mechanism that triggers when metadata (including metric selection) changes
- Refactored
showTopNodes()to use the currently selected metric instead of requiring it as a parameter - Fixed a CSS bug where the tooltip max-width calculation had a typo (used
+instead of-)
Reviewed changes
Copilot reviewed 8 out of 9 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| js-packages/web-console/src/lib/components/profiler/ProfilerTooltip.svelte | Fixed max-width calculation typo in tooltip styling |
| js-packages/web-console/src/lib/components/profiler/ProfilerLayout.svelte | Replaced event handler with reactive effect for metric changes; removed metric parameter from showTopNodes calls |
| js-packages/web-console/src/lib/components/profiler/ProfilerDiagram.svelte | Removed metric parameter from showTopNodes method signature |
| js-packages/profiler-lib/src/profiler.ts | Added tooltip refresh callback mechanism and refactored showTopNodes to use selected metric internally |
| js-packages/profiler-lib/src/metadataSelection.ts | Extracted notifyMetricsChanged into separate method for better code organization |
| js-packages/profiler-lib/src/cytograph.ts | Added callback invocation when tooltip context changes |
| js-packages/profiler-app/src/index.ts | Removed metric parameter from showTopNodes calls |
| js-packages/profiler-app/src/fileLoader.ts | Removed metric parameter from showTopNodes method signature |
| bun.lock | Updated dependency versions for @sveltejs/kit, svelte, and esrap |
| this.circuitSelector = null; | ||
| this.metadataSelector = null; | ||
| this.rendering = null; | ||
| this.onRefreshTooltip = null |
There was a problem hiding this comment.
Missing semicolon at end of statement. Add semicolon for consistency with project style.
Suggested change
| this.onRefreshTooltip = null | |
| this.onRefreshTooltip = null; |
| metricButton?.addEventListener('mouseover', () => loader.showTopNodes(false)); | ||
| metricButton?.addEventListener('mouseout', () => loader.hideNodeAttributes()); | ||
| metricButton?.addEventListener('click', () => loader.showTopNodes(metricSelector.value, true)); | ||
| metricButton?.addEventListener('click', () => loader.showTopNodes(true) ); |
There was a problem hiding this comment.
Inconsistent spacing before closing parenthesis. Remove the space before the closing parenthesis to match the formatting on line 228.
Suggested change
| metricButton?.addEventListener('click', () => loader.showTopNodes(true) ); | |
| metricButton?.addEventListener('click', () => loader.showTopNodes(true)); |
ryzhyk
approved these changes
Dec 30, 2025
Fix tooltip styles to not take up full height regardless of content Made table headers sticky Signed-off-by: Karakatiza666 <[email protected]>
Karakatiza666
force-pushed
the
profiler-fixes
branch
from
98f0d22 to
84861d8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please decide with @ryzhyk if we want this change; I believe it is clearly a better UX, and makes the behavior more intuitive.
Also: showTopNodes() method in profiler-lib no longer takes the selected metric as an argument because it is selected with a separate function call beforehand.