adapters: invoke only one s3 push operation at a time #5343
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors checkpoint synchronization to prevent multiple concurrent S3 push operations for the same checkpoint. The implementation replaces a faulty UUID-based locking mechanism with a RunningCheckpointSync state machine that mirrors the existing RunningCheckpoint pattern.
Key changes:
- Introduces
RunningCheckpointSyncenum to track sync operation lifecycle (Error/Waiting/Done states) - Replaces single
sync_checkpoint_requestwith a queue ofsync_checkpoint_requests - Adds polling mechanism to process queued sync requests after active sync completes
Removes the previous faulty implementation where we tried to take a lock on the UUID of a checkpoint when syncing it. The newer implementation mirrors the implementation of `RunningCheckpoint` to introduce `RunningCheckpointSync`. Once the sync is done running, all other sync requests made for the same checkpoint will be removed and marked as completed. Signed-off-by: Abhinav Gyawali <[email protected]>
abhizer
force-pushed
the
once-sync-at-a-time
branch
from
350de7a to
eefd011
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes the previous faulty implementation where we tried to take a lock on the UUID of a checkpoint when syncing it.
The newer implementation mirrors the implementation of
RunningCheckpointto introduceRunningCheckpointSync.Once the sync is done running, all other sync requests made for the same checkpoint will be removed and marked as completed.