pipeline-manager: deployment resources status details #5319
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds detailed status information for deployment resources and runtime status in the pipeline manager. The changes enable tracking of granular status details throughout the pipeline lifecycle (provisioning, provisioned, stopping states) to provide better visibility into pipeline deployment health and progress.
- Introduces
deployment_resources_status_detailsanddeployment_runtime_status_detailsfields to store JSON status information - Refactors the state machine to use
Actionenum with more granular state transitions includingRemainProvisioning,RemainProvisioned, andRemainStoppingactions - Updates the
PipelineExecutortrait to return status details fromis_provisioned()andcheck()methods
Reviewed changes
Copilot reviewed 16 out of 16 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| openapi.json | Adds nullable deployment_resources_status_details and deployment_runtime_status_details fields to API schema |
| crates/pipeline-manager/src/runner/pipeline_executor.rs | Introduces ProvisionStatus enum and updates trait methods to return status details |
| crates/pipeline-manager/src/runner/pipeline_automata.rs | Refactors state machine from State to Action enum with detailed transition handling and status detail tracking |
| crates/pipeline-manager/src/runner/local_runner.rs | Updates local runner implementation to provide status details |
| crates/pipeline-manager/src/runner/error.rs | Adds conversion from RunnerError to ErrorResponse |
| crates/pipeline-manager/src/error.rs | Adds conversion from ManagerError to ErrorResponse |
| crates/pipeline-manager/src/db/types/pipeline.rs | Adds status details fields to pipeline descriptor |
| crates/pipeline-manager/src/db/test.rs | Updates test code with new status details parameters |
| crates/pipeline-manager/src/db/storage_postgres.rs | Refactors database operations to handle status details with new remain_* methods |
| crates/pipeline-manager/src/db/storage.rs | Adds trait methods for remaining in current status while updating details |
| crates/pipeline-manager/src/db/operations/pipeline.rs | Splits status transition logic into separate methods for each transition type |
| crates/pipeline-manager/src/db/error.rs | Adds conversion from DBError to ErrorResponse |
| crates/pipeline-manager/src/api/support_data_collector.rs | Updates test calls with new status details parameters |
| crates/pipeline-manager/src/api/examples.rs | Adds status details fields to example data structures |
| crates/pipeline-manager/src/api/endpoints/pipeline_management.rs | Adds status details fields to API response structures |
| crates/pipeline-manager/migrations/V31__resources_details.sql | Adds database migration for new status details column |
snkas
force-pushed
the
monitor-pipeline
branch
from
bb2235e to
4129ad5
Compare
swanandx
left a comment
swanandx
left a comment
There was a problem hiding this comment.
Lot of places have remain_xx , methods / Action variants, they should be named correctly to signify their purpose ( i.e. update_details )
as the Nothing actions achieves the same goal, only when enough time has passed, we use remain instead of nothing right? I believe that might simplify things a bit.
snkas
force-pushed
the
monitor-pipeline
branch
from
4129ad5 to
37e6e5a
Compare
swanandx
left a comment
swanandx
left a comment
There was a problem hiding this comment.
I still have this question / suggestion #5319 (review)
but looks good overall! thanks! 🚀
Hmm, I'll try to think of better naming, but the difficulty is to not have every variable become very verbose. I'll change |
snkas
force-pushed
the
monitor-pipeline
branch
from
c19c0d5 to
3761ccf
Compare
snkas
force-pushed
the
monitor-pipeline
branch
from
ea73f54 to
f15ab67
Compare
Adds a new field `deployment_resources_status_details` with information about the status of the (Kubernetes) resources backing the pipeline. The `deployment_runtime_status_details` are now also regularly updated while the pipeline is provisioned. Signed-off-by: Simon Kassing <[email protected]>
snkas
force-pushed
the
monitor-pipeline
branch
from
f15ab67 to
7db4acd
Compare
Adds a new field
deployment_resources_status_detailswith information about the status of the (Kubernetes) resources backing the pipeline.The
deployment_runtime_status_detailsare now also regularly updated while the pipeline is provisioned.Remaining tasks
PR information