Fix SqlIdentifier implementation. #4968
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SqlIdentifier must convert the name to a canonical form during construction for PartialEq, etc. to be sound. Signed-off-by: Leonid Ryzhyk <[email protected]>
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the SqlIdentifier implementation to ensure sound equality comparison semantics. The key issue was that the constructor wasn't normalizing identifiers to their canonical form, which could cause PartialEq and related traits to behave incorrectly when comparing case-insensitive identifiers with different casing.
Key changes:
- Modified
SqlIdentifier::new()to convert case-insensitive identifiers to lowercase during construction
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
gz
reviewed
Oct 24, 2025
Contributor
gz
left a comment
gz
left a comment
There was a problem hiding this comment.
ok so it does change the semantics of sql_name
Contributor
Author
Yes, and I think it leaves less space for errors by eliminating the non-canonical representation of case-insensitive identifiers. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SqlIdentifier must convert the name to a canonical form during construction for PartialEq, etc. to be sound.