Skip to content

Conversation

@Karakatiza666
Copy link
Contributor

@Karakatiza666 Karakatiza666 commented Jun 27, 2025

I will squash commits before merging.

Part of #4219: Deprecate the JSON format for ad-hoc queries

@Karakatiza666 Karakatiza666 requested a review from gz June 27, 2025 08:49
@Karakatiza666 Karakatiza666 added Web Console Related to the browser based UI javascript Pull requests that update Javascript code adhoc Issue related to ad hoc query processing labels Jun 27, 2025
@Karakatiza666 Karakatiza666 force-pushed the webconsole-arrow branch 2 times, most recently from 56b7606 to 9c0a916 Compare June 27, 2025 09:04
@gz
Copy link
Contributor

gz commented Jun 27, 2025

It doesn't look like it answers queries (I tried fraud-detection), revision 9c0a916
https://github.com/user-attachments/assets/50f2fbc1-e59f-4638-ab97-31acd2746cad

@Karakatiza666
Copy link
Contributor Author

I think you encountered this one: #4239

Copy link
Contributor

@gz gz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm make sure to do
some testing before merging (different pipelines with different types (variant map etc.) and queries)

@gz
Copy link
Contributor

gz commented Jul 2, 2025

@Karakatiza666 can we merge this?

@Karakatiza666
Copy link
Contributor Author

Haven't had the chance to do a few tests with complex types, hopefully tomorrow

@Karakatiza666
Copy link
Contributor Author

Blocked by #4287
PR functions correctly, but triggers the above bug

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

adhoc Issue related to ad hoc query processing javascript Pull requests that update Javascript code Web Console Related to the browser based UI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants