Merged
Conversation
added 2 commits
April 20, 2021 12:43
GNSPS
approved these changes
Apr 21, 2021
added 2 commits
April 21, 2021 10:25
eswak
reviewed
Apr 21, 2021
contracts/pcv/EthPCVDripper.sol
Outdated
| uint256 public amountToDrip; | ||
|
|
||
| event Dripped(uint256 amount); | ||
| event Withdrawl(address indexed to, uint256 amount); |
Contributor
There was a problem hiding this comment.
small typo here in the event name
eswak
reviewed
Apr 21, 2021
contracts/pcv/IReserveStabilizer.sol
Outdated
|
|
||
| // ----------- State changing api ----------- | ||
|
|
||
| function exchangeFeiForEth(uint256 feiAmount) external returns (uint256); |
Contributor
There was a problem hiding this comment.
in the interface you probably want more generic names (a DaiReserverStabilizer with an exchangeFeiForEth function would be weird)
Contributor
Author
There was a problem hiding this comment.
renamed it to exchangeFei
Corsaire
reviewed
Apr 21, 2021
contracts/pcv/EthPCVDripper.sol
Outdated
| _initTimed(); | ||
|
|
||
| // drip | ||
| payable(target).sendValue(amountToDrip); |
There was a problem hiding this comment.
Would be good to only make the transfer if the target’s balance is lower than some threshold.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
EDIT: added the TribeDripper
Adds three contracts:
The FeiRewardsDistributor calculates the amount to release every week by taking the total balance of TRIBE and subtracting unreleased future rewards.
When a new TRIBE airdrop happens, it frontloads all the rewards for the weeks that have already passed into the first week.
For FIP-2 this would lead to 6x rewards in week 1 (1x base rewards + 100% boost x 5 drips) instead of 2x.
The TribeDripper drips in 47m, 31m, and 22m TRIBE each over the first 3 weeks to smoothen the distribution.
Week 1: 1x base rewards + 47% boost x 5 drips = ~3.35x
Week 2: 1.47x base rewards + 31% x 6 drips = ~3.33x
Week 3: 1.78x base rewards + 22% x 7 drips = ~3.32x
Week 4+: 2x base rewards
These would be voted on per FIP-2:
https://tribe.fei.money/t/fip-2-fei-redemption-tribe-staking/3033