Holding ERC20 deposits + deprecate PSMs#930
Merged
thomas-waite merged 42 commits intodeprecate-incentivesfrom Jun 29, 2022
Merged
Holding ERC20 deposits + deprecate PSMs#930thomas-waite merged 42 commits intodeprecate-incentivesfrom
thomas-waite merged 42 commits intodeprecate-incentivesfrom
Conversation
Joeysantoro
reviewed
Jun 22, 2022
Joeysantoro
reviewed
Jun 22, 2022
Joeysantoro
reviewed
Jun 22, 2022
thomas-waite
force-pushed
the
feat/empty-pcv-deposits
branch
from
82878f1 to
e86046d
Compare
thomas-waite
force-pushed
the
feat/empty-pcv-deposits
branch
from
2212bc3 to
24f912a
Compare
thomas-waite
commented
Jun 23, 2022
eswak
reviewed
Jun 23, 2022
eswak
reviewed
Jun 23, 2022
eswak
reviewed
Jun 23, 2022
eswak
reviewed
Jun 23, 2022
eswak
reviewed
Jun 28, 2022
eswak
reviewed
Jun 28, 2022
eswak
reviewed
Jun 28, 2022
eswak
reviewed
Jun 28, 2022
eswak
reviewed
Jun 28, 2022
eswak
reviewed
Jun 28, 2022
thomas-waite
commented
Jun 29, 2022
thomas-waite
commented
Jun 29, 2022
thomas-waite
commented
Jun 29, 2022
thomas-waite
commented
Jun 29, 2022
eswak
reviewed
Jun 29, 2022
| working_directory: ~/repo | ||
| executor: nodeimage | ||
| parallelism: 19 | ||
| parallelism: 16 |
Contributor
Author
There was a problem hiding this comment.
I've deleted a few e2e test files. The parallelism works like a loop - the number of parallel machines needs to match the number of jobs/files being sent.
If you send less than the number of parallel machines provisioned, then the extra machines start to run the entire e2e test suite each. Not 100% sure why, but essentially machines needs to match number of test files
eswak
approved these changes
Jun 29, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Empty holding PCV deposits + deprecate unneeded PSMs
Creates a new PCV deposit:
ERC20HoldingPCVDeposit.solwhich is just used as a safe harbour to assets that are remaining in the PCV.Deploys one of these pcv deposits for each of:
WETH,DAI,VOLT,LUSD.Also deprecates the PSMs that are no longer needed: ETH, LUSD and RAI. Deprecation involves:
The PR also adds the newly deployed holding PCV deposits to the CR.