Conversation
Contributor
Author
|
EDIT: deleted old calldata |
xklob
previously approved these changes
Jun 22, 2022
Contributor
thomas-waite
left a comment
thomas-waite
left a comment
There was a problem hiding this comment.
Looks good overall, few tidy up comments
proposals/dao/timelock_admin.ts
Outdated
Contributor
There was a problem hiding this comment.
Nit: Remove this console.log
| // This should exclusively include new contract deployments | ||
| const deploy: DeployUpgradeFunc = async (deployAddress: string, addresses: NamedAddresses, logging: boolean) => { | ||
| const factory = (await hre.ethers.getContractFactory('ERC20PCVDepositWrapper')) as ERC20PCVDepositWrapper__factory; | ||
| const rariTimelockFeiOldLens = await factory.deploy(addresses.rariInfraFeiTimelock, addresses.fei, true); |
Contributor
There was a problem hiding this comment.
Will make sure to add lenses for contracts with significant Fei that are becoming part of the Fei ecosystem in the future!
Contributor
There was a problem hiding this comment.
Would probably add a TIP number?
Contributor
There was a problem hiding this comment.
Think this is leftover commenting and needs deleting? tokemak_withdraw and tip_112 can both be removed.
pod_exec_v2 needs to stay here, it hasn't been proposed/executed by the TC yet
Joeysantoro
commented
Jun 22, 2022
|
|
||
| // Increase PCV balance to exceed deviation threshold | ||
| const pcvStats = await collateralizationOracleWrapper.pcvStats(); | ||
| await namedStaticPCVDepositWrapper.addDeposit({ |
Contributor
Author
There was a problem hiding this comment.
this test relies on named static PCV deposit which will be deprecated in this proposal. Erwan's #923 also deprecates the keeper
Contributor
thomas-waite
left a comment
thomas-waite
left a comment
There was a problem hiding this comment.
Looks fine to me, will give a final once over tomorrow then approve
| values: '0', | ||
| method: 'grantRole(bytes32,address)', | ||
| arguments: (addresses) => [ | ||
| '0x471cfe1a44bf1b786db7d7104d51e6728ed7b90a35394ad7cc424adf8ed16816', // SWAP_ADMIN_ROLE |
Contributor
There was a problem hiding this comment.
Nit, you can import ethers now and replace this with ethers.utils.id('SWAP_ADMIN_ROLE)
| expect(await contracts.namedStaticPCVDepositWrapper.numDeposits()).to.be.equal('0'); | ||
| expect(await contracts.ethToDaiLBPSwapper.swapEndTime()).to.be.gt( | ||
| ethers.BigNumber.from((await time.latest()).toString()) | ||
| ); |
Contributor
There was a problem hiding this comment.
Depends how confident are, but I would probably make sure you can do a swap via the LBP pool here
| false, | ||
| false | ||
| ], | ||
| description: 'Withdraw 10k ETH to LBP Swapper' |
Contributor
There was a problem hiding this comment.
Weights are 95 / 5 . You're sending $1m DAI and ~$10.5m ETH. So overfunding by $500k, should be fine
Contributor
Author
|
Calldata: Execute Calldata: |
thomas-waite
approved these changes
Jun 23, 2022
Contributor
thomas-waite
left a comment
thomas-waite
left a comment
There was a problem hiding this comment.
Looks okay to me. I would add a validation that you can do a swap and that the implied price is reasonable first if there's time.
Have verified the propose and execute calldata, looks good
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Type: Feature
PR Description:
Executes a few cleanup actions related to collateralization and operations:
PR Checklist - Feature (Proposal)