Skip to content

OA Cleanup#924

Merged
Joeysantoro merged 3 commits intofeat/cleanup-cr-oraclefrom
feat/cleanup-optimistic-approval
Jun 21, 2022
Merged

OA Cleanup#924
Joeysantoro merged 3 commits intofeat/cleanup-cr-oraclefrom
feat/cleanup-optimistic-approval

Conversation

@xklob
Copy link
Contributor

@xklob xklob commented Jun 20, 2022

PR Type: Feature

PR Title: OA Cleanup

PR Description: Deprecates the following roles from OA:

  • ORACLE_ADMIN ROLE
  • SWAP_ADMIN_ROLE
  • FUSE_ADMIN
  • PCV_GUARDIAN_ADMIN_ROLE
  • METAGOVERNANCE_GAUGE_ADMIN
  • PCV_MINOR_PARAM_ROLE
  • TOKEMAK_DEPOSIT_ADMIN_ROLE

PR Checklist - Feature (Non-Proposal)

  • All Tests Passing
  • Remove Any .only's on Tests

@xklob xklob requested a review from a team as a code owner June 20, 2022 22:58
@xklob xklob changed the base branch from develop to feat/cleanup-cr-oracle June 20, 2022 22:58
PSM_ADMIN_ROLE: ['tribalCouncilTimelock'],
TRIBAL_CHIEF_ADMIN_ROLE: ['optimisticTimelock', 'tribalCouncilTimelock'],
FUSE_ADMIN: ['optimisticTimelock', 'tribalCouncilTimelock'],
TRIBAL_CHIEF_ADMIN_ROLE: ['tribalCouncilTimelock'],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you never delete this role in this PR but tom does in #922

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure how I missed this - thanks

@Joeysantoro Joeysantoro merged commit d67b769 into feat/cleanup-cr-oracle Jun 21, 2022
@Joeysantoro Joeysantoro deleted the feat/cleanup-optimistic-approval branch June 21, 2022 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Comments