Cleanup: CR Oracle (remove caching, clean deprecated deposits)#923
Cleanup: CR Oracle (remove caching, clean deprecated deposits)#923thomas-waite merged 31 commits intodevelopfrom
Conversation
There was a problem hiding this comment.
there is also ~$15k FEI that should be withdrawn. tbh I'd include withdrawals for as many of these assets as possible:
- $15k FEI from d3Curve
- ~$1k FEI liquidity from d3Curve
- RAI in RAI psm
- FEI in RAI psm
- COMP in compoundETHPCVDepositWrapper
There was a problem hiding this comment.
adding calls for all of that.
since we're moving COMP from the deprecated ethCompoundPCVDeposit, I'll also move CRV/CVX from the deprecated convexD3PCVDeposit
TC multisig will have these assets to liquidate (though gnosis safe 1inch plugin?):
- 800k$ of RAI
- 800k$ of CRV/CVX
- 20k$ of COMP
let's not forget to do the permissionless harvests before this proposal's execution
There was a problem hiding this comment.
Might as well transfer in the remaining AAVE and COMP from the 2 live deposits too per https://snapshot.fei.money/#/proposal/0xf789539597a01bae85be052405854751737562f0832aab78f8d450d8afcb7bc3
…protocol-core into feat/cleanup-cr-oracle
…roval OA Cleanup
This reverts commit 445ac74.
Deprecate Ops Optimistic Timelock
…protocol-core into feat/cleanup-cr-oracle
thomas-waite
left a comment
thomas-waite
left a comment
There was a problem hiding this comment.
Think we can remove all Tokemak related actions apart from the TOKE withdrawal (already executed on-chain by the Guardian) and there's an action or two in the proposal that we can clean up
proposals/description/tip_117.ts
Outdated
There was a problem hiding this comment.
aaveEth should stay safe imo. Its the most convenient way for PCV Guardian to wrap ETH currently
There was a problem hiding this comment.
Thinking of adding to the ERC20HoldingPCVDeposit (Erwan's idea) a method to wrap any ETH the deposit has received. In the future we could use that to wrap ETH and then withdraw it to wherever it's needed
proposals/description/tip_117.ts
Outdated
There was a problem hiding this comment.
this should stay in too
4 participants
Deprecates the CR Oracle wrapper and cleanup the content of the CR Oracle (there are various PCVDeposits that are empty/deprecated, and roles that are granted to contracts that are not in use anymore)